mirrors/hermes-agent
1
0
Fork 0
mirror of https://github.com/NousResearch/hermes-agent.git synced 2026-05-07 02:51:50 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 7

fix(gateway): clear slack assistant thread status

Browse source
This commit is contained in:
Amr Essam 2026-04-30 10:28:10 +04:00 • committed by kshitij
parent a147164d3c
commit d05a87e686
2 changed files with 105 additions and 1 deletions
Download patch file Download diff file Expand all files Collapse all files

98
tests/gateway/test_slack.py
View file

@ -1153,6 +1153,104 @@ class TestSendTyping:
status="is thinking...",
)
@pytest.mark.asyncio
async def test_stop_typing_clears_tracked_thread(self, adapter):
adapter._app.client.assistant_threads_setStatus = AsyncMock()
await adapter.send_typing("C123", metadata={"thread_id": "parent_ts"})
await adapter.stop_typing("C123", metadata={"thread_id": "parent_ts"})
assert adapter._app.client.assistant_threads_setStatus.call_args_list[1] == call(
channel_id="C123",
thread_ts="parent_ts",
status="",
)
assert "C123" not in adapter._active_status_threads
@pytest.mark.asyncio
async def test_stop_typing_noop_without_tracked_thread(self, adapter):
adapter._app.client.assistant_threads_setStatus = AsyncMock()
await adapter.stop_typing("C123")
adapter._app.client.assistant_threads_setStatus.assert_not_called()
@pytest.mark.asyncio
async def test_stop_typing_handles_api_error_gracefully(self, adapter):
adapter._active_status_threads["C123"] = "parent_ts"
adapter._app.client.assistant_threads_setStatus = AsyncMock(
side_effect=Exception("missing_scope")
)
await adapter.stop_typing("C123")
adapter._app.client.assistant_threads_setStatus.assert_called_once_with(
channel_id="C123",
thread_ts="parent_ts",
status="",
)
assert "C123" not in adapter._active_status_threads
@pytest.mark.asyncio
async def test_send_clears_status_after_final_post(self, adapter):
adapter._app.client.chat_postMessage = AsyncMock(return_value={"ts": "reply_ts"})
adapter._app.client.assistant_threads_setStatus = AsyncMock()
adapter._active_status_threads["C123"] = "parent_ts"
result = await adapter.send("C123", "done", metadata={"thread_id": "parent_ts"})
assert result.success
adapter._app.client.chat_postMessage.assert_called_once()
adapter._app.client.assistant_threads_setStatus.assert_called_once_with(
channel_id="C123",
thread_ts="parent_ts",
status="",
)
assert "C123" not in adapter._active_status_threads
@pytest.mark.asyncio
async def test_streaming_final_edit_clears_status(self, adapter):
adapter._app.client.chat_update = AsyncMock()
adapter._app.client.assistant_threads_setStatus = AsyncMock()
adapter._active_status_threads["C123"] = "parent_ts"
result = await adapter.edit_message(
"C123",
"reply_ts",
"done",
finalize=True,
)
assert result.success
adapter._app.client.chat_update.assert_called_once_with(
channel="C123",
ts="reply_ts",
text="done",
)
adapter._app.client.assistant_threads_setStatus.assert_called_once_with(
channel_id="C123",
thread_ts="parent_ts",
status="",
)
assert "C123" not in adapter._active_status_threads
@pytest.mark.asyncio
async def test_streaming_intermediate_edit_keeps_status(self, adapter):
adapter._app.client.chat_update = AsyncMock()
adapter._app.client.assistant_threads_setStatus = AsyncMock()
adapter._active_status_threads["C123"] = "parent_ts"
result = await adapter.edit_message(
"C123",
"reply_ts",
"partial",
finalize=False,
)
assert result.success
adapter._app.client.assistant_threads_setStatus.assert_not_called()
assert adapter._active_status_threads["C123"] == "parent_ts"
# ---------------------------------------------------------------------------
# TestFormatMessage — Markdown → mrkdwn conversion