mirrors/hermes-agent
1
0
Fork 0
mirror of https://github.com/NousResearch/hermes-agent.git synced 2026-07-31 19:16:29 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 2

test(slack): importorskip real slack_sdk/slack_bolt in transient-edit tests

Browse source 
CI shards run without the slack extras; the two #64267 tests import the
real SDK (SlackApiError, the lazy-rebind path) and errored with
ModuleNotFoundError. Skip on bare environments — classification coverage
for stdlib exception types (OSError/TimeoutError/cert errors) still runs
everywhere.
This commit is contained in:
Teknium 2026-07-23 09:49:15 -07:00
parent 21ac2b50dc
commit ca988df8d0
1 changed files with 10 additions and 1 deletions
Download patch file Download diff file Expand all files Collapse all files

11
tests/gateway/test_slack_block_kit_adapter.py
View file

@ -236,7 +236,12 @@ class TestEditMessageBlocks:
@pytest.mark.asyncio
async def test_slack_api_error_on_edit_is_not_retryable(self):
from slack_sdk.errors import SlackApiError
# Real slack_sdk required: the test pins that a genuine SlackApiError
# is never misclassified as transient. CI shards without the slack
# extras skip (adapter classification is still covered by the
# OSError/timeout tests above, which use stdlib exceptions).
errors_mod = pytest.importorskip("slack_sdk.errors")
SlackApiError = errors_mod.SlackApiError
adapter, client = _make_adapter()
client.chat_update = AsyncMock(
@ -309,6 +314,10 @@ class TestEditMessageBlocks:
async def test_lazy_rebound_aiohttp_connection_error_is_retryable(
self, monkeypatch
):
# Exercises the REAL lazy-import rebind path in
# check_slack_requirements — requires slack_bolt/slack_sdk installed.
pytest.importorskip("slack_bolt")
pytest.importorskip("slack_sdk")
import tools.lazy_deps as lazy_deps
monkeypatch.setattr(slack_module, "SLACK_AVAILABLE", False)