test(gateway): pin DEFAULT_DB_PATH in fixtures to prevent real state.db writes

Fixtures that instantiate SessionStore() trigger SessionDB() with no args,
which resolves to ~/.hermes/state.db via the DEFAULT_DB_PATH module constant
(snapshot of get_hermes_home() at hermes_state import time).

The autouse _hermetic_environment fixture in tests/conftest.py monkeypatches
HERMES_HOME env, but DEFAULT_DB_PATH is already cached by then. Per-test
monkeypatch.setattr(hermes_state, 'DEFAULT_DB_PATH', tmp_path/'state.db')
forces the DB into tmp_path so the tests can't leak into the real profile.

Verified by counting u1-prefixed sessions in real state.db before/after:
delta=0.
This commit is contained in:
yoniebans 2026-05-20 11:08:06 +02:00 committed by Teknium
parent 33a3cf5322
commit c634c07bcc
4 changed files with 40 additions and 14 deletions

View file

@ -504,7 +504,9 @@ class TestSessionStoreRewriteTranscript:
"""Regression: /retry and /undo must persist truncated history to DB."""
@pytest.fixture()
def store(self, tmp_path):
def store(self, tmp_path, monkeypatch):
import hermes_state
monkeypatch.setattr(hermes_state, "DEFAULT_DB_PATH", tmp_path / "state.db")
config = GatewayConfig()
s = SessionStore(sessions_dir=tmp_path, config=config)
return s
@ -546,13 +548,17 @@ class TestSessionStoreRewriteTranscript:
class TestLoadTranscriptDBOnly:
"""After spec 002, load_transcript reads only from state.db."""
def test_db_only_returns_empty_for_nonexistent(self, tmp_path):
def test_db_only_returns_empty_for_nonexistent(self, tmp_path, monkeypatch):
import hermes_state
monkeypatch.setattr(hermes_state, "DEFAULT_DB_PATH", tmp_path / "state.db")
config = GatewayConfig()
store = SessionStore(sessions_dir=tmp_path, config=config)
result = store.load_transcript("nonexistent")
assert result == []
def test_db_only_returns_messages(self, tmp_path):
def test_db_only_returns_messages(self, tmp_path, monkeypatch):
import hermes_state
monkeypatch.setattr(hermes_state, "DEFAULT_DB_PATH", tmp_path / "state.db")
config = GatewayConfig()
store = SessionStore(sessions_dir=tmp_path, config=config)
sid = "db_only_session"