mirrors/hermes-agent
1
0
Fork 0
mirror of https://github.com/NousResearch/hermes-agent.git synced 2026-06-04 07:31:58 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 11

test(gateway): pin DEFAULT_DB_PATH in fixtures to prevent real state.db writes

Browse source 
Fixtures that instantiate SessionStore() trigger SessionDB() with no args,
which resolves to ~/.hermes/state.db via the DEFAULT_DB_PATH module constant
(snapshot of get_hermes_home() at hermes_state import time).

The autouse _hermetic_environment fixture in tests/conftest.py monkeypatches
HERMES_HOME env, but DEFAULT_DB_PATH is already cached by then. Per-test
monkeypatch.setattr(hermes_state, 'DEFAULT_DB_PATH', tmp_path/'state.db')
forces the DB into tmp_path so the tests can't leak into the real profile.

Verified by counting u1-prefixed sessions in real state.db before/after:
delta=0.
This commit is contained in:
yoniebans 2026-05-20 11:08:06 +02:00 • committed by Teknium
parent 33a3cf5322
commit c634c07bcc
4 changed files with 40 additions and 14 deletions
Download patch file Download diff file Expand all files Collapse all files

19
tests/gateway/test_load_transcript_db_only.py
View file

@ -1,13 +1,23 @@
"""Verify load_transcript returns SQLite messages without any JSONL file."""
from pathlib import Path
import pytest
from gateway.session import SessionStore
from gateway.config import GatewayConfig
def test_load_transcript_returns_db_messages_when_no_jsonl(tmp_path):
"""Reading a transcript must work from SQLite alone — no JSONL fallback needed."""
def test_load_transcript_returns_db_messages_when_no_jsonl(tmp_path, monkeypatch):
"""Reading a transcript must work from SQLite alone — no JSONL fallback needed.
Pin DEFAULT_DB_PATH to tmp_path so this test cannot write to the real
~/.hermes/state.db. (DEFAULT_DB_PATH is a module-level constant computed
at hermes_state import time, before pytest's HERMES_HOME monkeypatch
fires — the autouse fixture's HERMES_HOME override doesn't help here.)
"""
import hermes_state
monkeypatch.setattr(hermes_state, "DEFAULT_DB_PATH", tmp_path / "state.db")
config = GatewayConfig()
store = SessionStore(sessions_dir=tmp_path, config=config)
@ -16,11 +26,6 @@ def test_load_transcript_returns_db_messages_when_no_jsonl(tmp_path):
store.append_to_transcript(sid, {"role": "user", "content": "hello", "timestamp": 1.0})
store.append_to_transcript(sid, {"role": "assistant", "content": "world", "timestamp": 2.0})
# Delete any JSONL that the current dual-writer left behind
jsonl_path = tmp_path / f"{sid}.jsonl"
if jsonl_path.exists():
jsonl_path.unlink()
history = store.load_transcript(sid)
assert len(history) == 2
assert history[0]["content"] == "hello"