From c084085a3e520178fb3aa27c6ba7a411df8c79a0 Mon Sep 17 00:00:00 2001 From: Teknium <127238744+teknium1@users.noreply.github.com> Date: Tue, 14 Jul 2026 06:24:29 -0700 Subject: [PATCH] test: remove flaky test_crashed_runner_produces_error_completion (#64431) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Flaked 3 times today across 3 unrelated PRs (#64321, #64319, #64409), on two different CI shards (slice 1 and slice 8), while passing deterministically on local runs of the same SHAs. The test polls process_registry.completion_queue for 5s waiting for a daemon-thread completion event; since the durable completion delivery work (67f4e1b4a, d0e9a42ce) the crashed-runner path also writes through the sqlite-backed persistence layer, and on slow CI runners the in-memory enqueue can lose the 5s race. Coverage note: the durable-delivery suite in this file covers the completed-runner and submit-failure paths through persistence, but not a runner that raises mid-flight — that specific path loses its direct test with this removal. A deterministic (non-racing) replacement can follow separately if wanted. --- tests/tools/test_async_delegation.py | 18 ------------------ 1 file changed, 18 deletions(-) diff --git a/tests/tools/test_async_delegation.py b/tests/tools/test_async_delegation.py index 77732960bcaf..cc4f7651d364 100644 --- a/tests/tools/test_async_delegation.py +++ b/tests/tools/test_async_delegation.py @@ -167,24 +167,6 @@ def test_dispatch_rejected_at_capacity(): ev.set() -def test_crashed_runner_produces_error_completion(): - def boom(): - raise RuntimeError("subagent exploded") - - r = ad.dispatch_async_delegation( - goal="risky", context=None, toolsets=None, role="leaf", model="m", - session_key="", runner=boom, max_async_children=3, - ) - assert r["status"] == "dispatched" - evt = _drain_one() - assert evt is not None - assert evt["status"] == "error" - text = format_process_notification(evt) - assert text is not None - assert "did not complete successfully" in text - assert "subagent exploded" in text - - def test_interrupt_all_signals_running_children(): ev = threading.Event() interrupted = {"count": 0}