feat(gateway): inject stable human-readable message timestamps

Consolidates these related Amy fork patches:
- 429830f39 feat(gateway): inject message timestamps into user messages for LLM context
- 3c3d6fac0 fix: handle both ISO string and epoch float timestamps in history replay
- 2874f7725 feat: human-friendly timestamp format with weekday and timezone name
- 3735f4c8b fix: render gateway message timestamps once
This commit is contained in:
Wolfram Ravenwolf 2026-05-18 03:51:58 +02:00 committed by Teknium
parent b7f0c9cd52
commit bd7fc8fdcd
13 changed files with 448 additions and 28 deletions

View file

@ -211,7 +211,10 @@ class TestListAndCleanup:
db = manager._get_db()
messages = db.get_messages_as_conversation(state.session_id)
assert messages == [{"role": "user", "content": "original"}]
assert len(messages) == 1
assert messages[0]["role"] == "user"
assert messages[0]["content"] == "original"
assert isinstance(messages[0].get("timestamp"), (int, float))
def test_cleanup_clears_all(self, manager):
s1 = manager.create_session()
@ -501,6 +504,8 @@ class TestPersistence:
restored = manager.get_session(state.session_id)
assert restored is not None
msg = restored.history[0]
assert isinstance(msg.pop("timestamp", None), (int, float))
assert restored.history == [{
"role": "assistant",
"content": "hello",

View file

@ -23,12 +23,20 @@ class _CapturingAgent:
type(self).last_init = dict(kwargs)
self.tools = []
def run_conversation(self, user_message, conversation_history=None, task_id=None, persist_user_message=None):
def run_conversation(
self,
user_message,
conversation_history=None,
task_id=None,
persist_user_message=None,
persist_user_timestamp=None,
):
type(self).last_run = {
"user_message": user_message,
"conversation_history": conversation_history,
"task_id": task_id,
"persist_user_message": persist_user_message,
"persist_user_timestamp": persist_user_timestamp,
}
return {
"final_response": "ok",

View file

@ -0,0 +1,91 @@
from datetime import datetime
from zoneinfo import ZoneInfo
from gateway.message_timestamps import (
coerce_message_timestamp,
render_user_content_with_timestamp,
strip_leading_message_timestamps,
)
from run_agent import AIAgent
BERLIN = ZoneInfo("Europe/Berlin")
def _epoch(year, month, day, hour, minute, second):
return datetime(year, month, day, hour, minute, second, tzinfo=BERLIN).timestamp()
def test_render_user_content_adds_single_context_timestamp():
ts = _epoch(2026, 4, 28, 13, 40, 53)
rendered = render_user_content_with_timestamp(
"[Example User] Timestamp should be in context",
ts,
tz=BERLIN,
)
assert rendered == (
"[Tue 2026-04-28 13:40:53 CEST] "
"[Example User] Timestamp should be in context"
)
def test_render_user_content_deduplicates_existing_timestamp_and_preserves_embedded_time():
db_processing_ts = _epoch(2026, 4, 27, 15, 55, 36)
stored_content = (
"[Mon 2026-04-27 15:54:44 CEST] "
"[Example User] This should go on our todo list"
)
rendered = render_user_content_with_timestamp(
stored_content,
db_processing_ts,
tz=BERLIN,
)
assert rendered == stored_content
assert rendered.count("2026-04-27") == 1
def test_strip_leading_message_timestamps_removes_multiple_prefixes_and_prefers_inner_time():
content = (
"[Mon 2026-04-27 15:55:36 CEST] "
"[Mon 2026-04-27 15:54:44 CEST] "
"[Example User] This should go on our todo list"
)
stripped, embedded_ts = strip_leading_message_timestamps(content, tz=BERLIN)
assert stripped == "[Example User] This should go on our todo list"
assert embedded_ts == _epoch(2026, 4, 27, 15, 54, 44)
def test_coerce_message_timestamp_accepts_datetime_and_epoch():
dt = datetime(2026, 4, 28, 13, 40, 53, tzinfo=BERLIN)
assert coerce_message_timestamp(dt, tz=BERLIN) == dt.timestamp()
assert coerce_message_timestamp(dt.timestamp(), tz=BERLIN) == dt.timestamp()
def test_persist_user_message_override_keeps_clean_content_and_timestamp_metadata():
agent = AIAgent.__new__(AIAgent)
agent._persist_user_message_idx = 0
agent._persist_user_message_override = "[Example User] Clean content"
agent._persist_user_message_timestamp = _epoch(2026, 4, 28, 13, 40, 53)
messages = [
{
"role": "user",
"content": "[Tue 2026-04-28 13:40:53 CEST] [Example User] Clean content",
}
]
agent._apply_persist_user_message_override(messages)
assert messages == [
{
"role": "user",
"content": "[Example User] Clean content",
"timestamp": _epoch(2026, 4, 28, 13, 40, 53),
}
]

View file

@ -241,7 +241,11 @@ async def test_session_chat_loads_history_and_preserves_session_headers(auth_ada
assert kwargs["session_id"] == session_id
assert kwargs["gateway_session_key"] == "client-42"
assert kwargs["ephemeral_system_prompt"] == "stay focused"
assert kwargs["conversation_history"] == [
history = kwargs["conversation_history"]
assert len(history) == 2
assert isinstance(history[0].pop("timestamp"), (int, float))
assert isinstance(history[1].pop("timestamp"), (int, float))
assert history == [
{"role": "user", "content": "earlier"},
{"role": "assistant", "content": "prior answer"},
]

View file

@ -347,6 +347,15 @@ class TestMessageStorage:
assert messages[0]["content"] == "Hello"
assert messages[1]["role"] == "assistant"
def test_append_message_accepts_explicit_timestamp(self, db):
db.create_session(session_id="s1", source="telegram")
event_ts = 1777383653.0
db.append_message("s1", role="user", content="Hello", timestamp=event_ts)
messages = db.get_messages_as_conversation("s1")
assert messages[0]["timestamp"] == event_ts
def test_message_increments_session_count(self, db):
db.create_session(session_id="s1", source="cli")
db.append_message("s1", role="user", content="Hello")
@ -370,11 +379,10 @@ class TestMessageStorage:
assert messages[1]["observed"] == 0
conversation = db.get_messages_as_conversation("s1")
assert conversation[0] == {
"role": "user",
"content": "[Alice|111]\nside chatter",
"observed": True,
}
assert conversation[0]["role"] == "user"
assert conversation[0]["content"] == "[Alice|111]\nside chatter"
assert conversation[0]["observed"] is True
assert isinstance(conversation[0].get("timestamp"), float)
assert "observed" not in conversation[1]
def test_tool_response_does_not_increment_tool_count(self, db):
@ -458,7 +466,9 @@ class TestMessageStorage:
# get_messages_as_conversation decodes back to the original list
conv = db.get_messages_as_conversation("s1")
assert len(conv) == 1
assert conv[0] == {"role": "user", "content": content}
assert conv[0]["role"] == "user"
assert conv[0]["content"] == content
assert isinstance(conv[0].get("timestamp"), float)
def test_dict_content_round_trip(self, db):
"""Dict-shaped content (e.g. provider wrappers) also round-trips."""
@ -529,8 +539,12 @@ class TestMessageStorage:
conv = db.get_messages_as_conversation("s1")
assert len(conv) == 2
assert conv[0] == {"role": "user", "content": "Hello"}
assert conv[1] == {"role": "assistant", "content": "Hi!"}
assert conv[0]["role"] == "user"
assert conv[0]["content"] == "Hello"
assert isinstance(conv[0]["timestamp"], float)
assert conv[1]["role"] == "assistant"
assert conv[1]["content"] == "Hi!"
assert isinstance(conv[1]["timestamp"], float)
def test_platform_message_id_round_trips(self, db):
"""Platform-side message ids (yuanbao msg_id, telegram update_id, …)
@ -620,7 +634,10 @@ class TestMessageStorage:
)
conv = db.get_messages_as_conversation("s1")
assert conv == [{"role": "assistant", "content": "Visible answer"}]
assert len(conv) == 1
assert conv[0]["role"] == "assistant"
assert conv[0]["content"] == "Visible answer"
assert isinstance(conv[0].get("timestamp"), float)
def test_reasoning_persisted_and_restored(self, db):
"""Reasoning text is stored for assistant messages and restored by