mirrors/hermes-agent
1
0
Fork 0
mirror of https://github.com/NousResearch/hermes-agent.git synced 2026-05-02 02:01:47 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 6

fix(tui): preserve completed thinking panel

Browse source
This commit is contained in:
Brooklyn Nicholson 2026-04-26 13:49:41 -05:00
parent 4a21920b5e
commit bb59d3bac2
3 changed files with 31 additions and 25 deletions
Download patch file Download diff file Expand all files Collapse all files

34
ui-tui/src/__tests__/createGatewayEventHandler.test.ts
View file

@ -82,13 +82,12 @@ describe('createGatewayEventHandler', () => {
type: 'message.complete'
} as any)
expect(appended).toHaveLength(3)
expect(appended).toHaveLength(2)
expect(appended[0]).toMatchObject({ kind: 'trail', role: 'system', text: '', thinking: 'mapped the page' })
expect(appended[1]).toMatchObject({ kind: 'trail', role: 'system', text: '' })
expect(appended[1]?.tools).toHaveLength(1)
expect(appended[1]?.tools?.[0]).toContain('hero cards')
expect(appended[1]?.toolTokens).toBeGreaterThan(0)
expect(appended[2]).toMatchObject({ role: 'assistant', text: 'final answer' })
expect(appended[0]?.tools).toHaveLength(1)
expect(appended[0]?.tools?.[0]).toContain('hero cards')
expect(appended[0]?.toolTokens).toBeGreaterThan(0)
expect(appended[1]).toMatchObject({ role: 'assistant', text: 'final answer' })
})
it('keeps tool tokens across handler recreation mid-turn', () => {
@ -116,10 +115,10 @@ describe('createGatewayEventHandler', () => {
type: 'message.complete'
} as any)
expect(appended).toHaveLength(3)
expect(appended[1]?.tools).toHaveLength(1)
expect(appended[1]?.toolTokens).toBeGreaterThan(0)
expect(appended[2]).toMatchObject({ role: 'assistant', text: 'final answer' })
expect(appended).toHaveLength(2)
expect(appended[0]?.tools).toHaveLength(1)
expect(appended[0]?.toolTokens).toBeGreaterThan(0)
expect(appended[1]).toMatchObject({ role: 'assistant', text: 'final answer' })
})
it('streams legacy thinking.delta into visible reasoning state', () => {
@ -136,6 +135,21 @@ describe('createGatewayEventHandler', () => {
vi.useRealTimers()
})
it('preserves streamed reasoning as one completed thinking panel after segment flushes', () => {
const appended: Msg[] = []
const streamed = 'first reasoning chunk\nsecond reasoning chunk'
const onEvent = createGatewayEventHandler(buildCtx(appended))
onEvent({ payload: { text: streamed }, type: 'reasoning.delta' } as any)
onEvent({ payload: { text: 'Before edit.' }, type: 'message.delta' } as any)
turnController.flushStreamingSegment()
onEvent({ payload: { text: 'final answer' }, type: 'message.complete' } as any)
expect(appended.map(msg => msg.thinking).filter(Boolean)).toEqual([streamed])
expect(appended[appended.length - 1]).toMatchObject({ role: 'assistant', text: 'final answer' })
})
it('ignores fallback reasoning.available when streamed reasoning already exists', () => {
const appended: Msg[] = []
const streamed = 'short streamed reasoning'