diff --git a/tests/tools/test_file_read_guards.py b/tests/tools/test_file_read_guards.py index ccb82daa734..8f38aab7b07 100644 --- a/tests/tools/test_file_read_guards.py +++ b/tests/tools/test_file_read_guards.py @@ -78,7 +78,23 @@ class TestDevicePathBlocking(unittest.TestCase): def test_proc_fd_other_not_blocked(self): self.assertFalse(_is_blocked_device("/proc/self/fd/3")) - self.assertFalse(_is_blocked_device("/proc/self/maps")) + + def test_proc_sensitive_pseudo_files_blocked(self): + """environ/cmdline/maps under /proc/ must be blocked (issue #4427).""" + for path in ( + "/proc/self/environ", + "/proc/12345/environ", + "/proc/self/cmdline", + "/proc/99/cmdline", + "/proc/self/maps", + "/proc/1/maps", + ): + self.assertTrue(_is_blocked_device(path), f"{path} should be blocked") + + def test_proc_legitimate_files_not_blocked(self): + """Top-level /proc files like cpuinfo and meminfo must remain accessible.""" + for path in ("/proc/cpuinfo", "/proc/meminfo", "/proc/uptime", "/proc/version"): + self.assertFalse(_is_blocked_device(path), f"{path} should not be blocked") def test_normal_files_not_blocked(self): self.assertFalse(_is_blocked_device("/tmp/test.py")) diff --git a/tools/file_tools.py b/tools/file_tools.py index 9ff433ef939..27b768e93cf 100644 --- a/tools/file_tools.py +++ b/tools/file_tools.py @@ -143,6 +143,12 @@ def _is_blocked_device(filepath: str) -> bool: ("/fd/0", "/fd/1", "/fd/2") ): return True + # /proc/*/environ, /proc/*/cmdline, /proc/*/maps can leak secrets, + # command-line args, and memory layout from the host process (issue #4427) + if normalized.startswith("/proc/") and normalized.endswith( + ("/environ", "/cmdline", "/maps") + ): + return True return False