mirrors/hermes-agent
1
0
Fork 0
mirror of https://github.com/NousResearch/hermes-agent.git synced 2026-07-08 13:12:08 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 6

test(error-classifier): parametrize 5xx overflow test over 500/502/503/529

Browse source 
Review nit (helix4u): the fix covers 500/502/503/529 but the positive tests
only asserted 500 and 503. Parametrize over all four so 502/529 are covered
too; keep the plain-5xx negatives.
This commit is contained in:
kshitijk4poor 2026-07-01 15:47:46 +05:30 • committed by kshitij
parent a04b7024ff
commit b7adad1a72
1 changed files with 8 additions and 15 deletions
Download patch file Download diff file Expand all files Collapse all files

23
tests/agent/test_error_classifier.py
View file

@ -476,29 +476,22 @@ class TestClassifyApiError:
# compression-and-retry path, not the blind server_error/overloaded retry
# that exhausts and drops the turn.
def test_500_context_overflow_routes_to_compression(self):
"""A llama.cpp 500 'Context size has been exceeded.' must compress."""
@pytest.mark.parametrize("status_code", [500, 502, 503, 529])
def test_5xx_context_overflow_routes_to_compression(self, status_code):
"""Explicit context-overflow wording on any of the codes the fix covers
(500/502/503/529) must route to context_overflow + compression, not a
blind server_error/overloaded retry. Covers all four branches the code
touches (the original PR only asserted 500 and 503)."""
e = MockAPIError(
"Context size has been exceeded.",
status_code=500,
body={"error": {"code": 500, "message": "Context size has been exceeded.", "type": "server_error"}},
status_code=status_code,
body={"error": {"code": status_code, "message": "Context size has been exceeded.", "type": "server_error"}},
)
result = classify_api_error(e)
assert result.reason == FailoverReason.context_overflow
assert result.should_compress is True
assert result.retryable is True
def test_503_context_overflow_routes_to_compression(self):
"""An overflow surfaced as 503 (busy / model-load OOM) must compress."""
e = MockAPIError(
"the request exceeds the available context size",
status_code=503,
body={"error": {"message": "the request exceeds the available context size"}},
)
result = classify_api_error(e)
assert result.reason == FailoverReason.context_overflow
assert result.should_compress is True
def test_500_plain_server_error_not_compressed(self):
"""A genuine 500 crash without overflow wording must NOT be swallowed
into compression — it stays a retryable server_error."""