mirror of
https://github.com/NousResearch/hermes-agent.git
synced 2026-04-25 00:51:20 +00:00
fix: preserve parent agent's tool list after subagent delegation (#1778)
Save and restore the process-global _last_resolved_tool_names in _run_single_child() so the parent's execute_code sandbox generates correct tool imports after delegation completes. The global was already mostly mitigated (run_agent.py passes enabled_tools via self.valid_tool_names), but the global itself remained corrupted — a footgun for any code that reads it directly. Co-authored-by: shane9coy <shane9coy@users.noreply.github.com>
This commit is contained in:
parent
9a1e971126
commit
b5cf0f0aef
3 changed files with 53 additions and 1 deletions
|
|
@ -249,6 +249,49 @@ class TestDelegateTask(unittest.TestCase):
|
|||
self.assertEqual(kwargs["api_mode"], parent.api_mode)
|
||||
|
||||
|
||||
class TestToolNamePreservation(unittest.TestCase):
|
||||
"""Verify _last_resolved_tool_names is restored after subagent runs."""
|
||||
|
||||
def test_global_tool_names_restored_after_delegation(self):
|
||||
"""The process-global _last_resolved_tool_names must be restored
|
||||
after a subagent completes so the parent's execute_code sandbox
|
||||
generates correct imports."""
|
||||
import model_tools
|
||||
|
||||
parent = _make_mock_parent(depth=0)
|
||||
original_tools = ["terminal", "read_file", "web_search", "execute_code", "delegate_task"]
|
||||
model_tools._last_resolved_tool_names = list(original_tools)
|
||||
|
||||
with patch("run_agent.AIAgent") as MockAgent:
|
||||
mock_child = MagicMock()
|
||||
mock_child.run_conversation.return_value = {
|
||||
"final_response": "done", "completed": True, "api_calls": 1,
|
||||
}
|
||||
MockAgent.return_value = mock_child
|
||||
|
||||
delegate_task(goal="Test tool preservation", parent_agent=parent)
|
||||
|
||||
self.assertEqual(model_tools._last_resolved_tool_names, original_tools)
|
||||
|
||||
def test_global_tool_names_restored_after_child_failure(self):
|
||||
"""Even when the child agent raises, the global must be restored."""
|
||||
import model_tools
|
||||
|
||||
parent = _make_mock_parent(depth=0)
|
||||
original_tools = ["terminal", "read_file", "web_search"]
|
||||
model_tools._last_resolved_tool_names = list(original_tools)
|
||||
|
||||
with patch("run_agent.AIAgent") as MockAgent:
|
||||
mock_child = MagicMock()
|
||||
mock_child.run_conversation.side_effect = RuntimeError("boom")
|
||||
MockAgent.return_value = mock_child
|
||||
|
||||
result = json.loads(delegate_task(goal="Crash test", parent_agent=parent))
|
||||
self.assertEqual(result["results"][0]["status"], "error")
|
||||
|
||||
self.assertEqual(model_tools._last_resolved_tool_names, original_tools)
|
||||
|
||||
|
||||
class TestDelegateObservability(unittest.TestCase):
|
||||
"""Tests for enriched metadata returned by _run_single_child."""
|
||||
|
||||
|
|
|
|||
Loading…
Add table
Add a link
Reference in a new issue