From b49bd7b93d1c2b8126dc87f9181487dcb23df7e1 Mon Sep 17 00:00:00 2001 From: alt-glitch Date: Fri, 24 Apr 2026 07:36:03 +0530 Subject: [PATCH] Fix ACP module path documentation from acp_adapter to hermes_agent.acp --- AGENTS.md | 2 +- website/docs/developer-guide/acp-internals.md | 30 +++++++++---------- website/docs/developer-guide/architecture.md | 4 +-- website/docs/reference/cli-commands.md | 2 +- website/docs/user-guide/features/acp.md | 4 +-- 5 files changed, 21 insertions(+), 21 deletions(-) diff --git a/AGENTS.md b/AGENTS.md index 0f5ce15f2..352b0bb5a 100644 --- a/AGENTS.md +++ b/AGENTS.md @@ -69,7 +69,7 @@ hermes-agent/ │ ├── server.py # RPC handlers and session logic │ ├── render.py # Optional rich/ANSI bridge │ └── slash_worker.py # Persistent HermesCLI subprocess for slash commands -├── acp_adapter/ # ACP server (VS Code / Zed / JetBrains integration) +├── hermes_agent/acp/ # ACP server (VS Code / Zed / JetBrains integration) ├── cron/ # Scheduler (jobs.py, scheduler.py) ├── environments/ # RL training environments (Atropos) ├── tests/ # Pytest suite (~3000 tests) diff --git a/website/docs/developer-guide/acp-internals.md b/website/docs/developer-guide/acp-internals.md index 0db8d94cd..a75b5e58b 100644 --- a/website/docs/developer-guide/acp-internals.md +++ b/website/docs/developer-guide/acp-internals.md @@ -10,20 +10,20 @@ The ACP adapter wraps Hermes' synchronous `AIAgent` in an async JSON-RPC stdio s Key implementation files: -- `acp_adapter/entry.py` -- `acp_adapter/server.py` -- `acp_adapter/session.py` -- `acp_adapter/events.py` -- `acp_adapter/permissions.py` -- `acp_adapter/tools.py` -- `acp_adapter/auth.py` +- `hermes_agent/acp/entry.py` +- `hermes_agent/acp/server.py` +- `hermes_agent/acp/session.py` +- `hermes_agent/acp/events.py` +- `hermes_agent/acp/permissions.py` +- `hermes_agent/acp/tools.py` +- `hermes_agent/acp/auth.py` - `acp_registry/agent.json` ## Boot flow ```text -hermes acp / hermes-acp / python -m acp_adapter - -> acp_adapter.entry.main() +hermes acp / hermes-acp / python -m hermes_agent.acp + -> hermes_agent.acp.entry.main() -> load ~/.hermes/.env -> configure stderr logging -> construct HermesACPAgent @@ -36,7 +36,7 @@ Stdout is reserved for ACP JSON-RPC transport. Human-readable logs go to stderr. ### `HermesACPAgent` -`acp_adapter/server.py` implements the ACP agent protocol. +`hermes_agent/acp/server.py` implements the ACP agent protocol. Responsibilities: @@ -48,7 +48,7 @@ Responsibilities: ### `SessionManager` -`acp_adapter/session.py` tracks live ACP sessions. +`hermes_agent/acp/session.py` tracks live ACP sessions. Each session stores: @@ -71,7 +71,7 @@ The manager is thread-safe and supports: ### Event bridge -`acp_adapter/events.py` converts AIAgent callbacks into ACP `session_update` events. +`hermes_agent/acp/events.py` converts AIAgent callbacks into ACP `session_update` events. Bridged callbacks: @@ -88,7 +88,7 @@ asyncio.run_coroutine_threadsafe(...) ### Permission bridge -`acp_adapter/permissions.py` adapts dangerous terminal approval prompts into ACP permission requests. +`hermes_agent/acp/permissions.py` adapts dangerous terminal approval prompts into ACP permission requests. Mapping: @@ -100,7 +100,7 @@ Timeouts and bridge failures deny by default. ### Tool rendering helpers -`acp_adapter/tools.py` maps Hermes tools to ACP tool kinds and builds editor-facing content. +`hermes_agent/acp/tools.py` maps Hermes tools to ACP tool kinds and builds editor-facing content. Examples: @@ -144,7 +144,7 @@ ACP does not implement its own auth store. Instead it reuses Hermes' runtime resolver: -- `acp_adapter/auth.py` +- `hermes_agent/acp/auth.py` - `hermes_cli/runtime_provider.py` So ACP advertises and uses the currently configured Hermes provider/credentials. diff --git a/website/docs/developer-guide/architecture.md b/website/docs/developer-guide/architecture.md index 88ad96269..b779e632c 100644 --- a/website/docs/developer-guide/architecture.md +++ b/website/docs/developer-guide/architecture.md @@ -14,7 +14,7 @@ This page is the top-level map of Hermes Agent internals. Use it to orient yours ┌─────────────────────────────────────────────────────────────────────┐ │ Entry Points │ │ │ -│ CLI (cli.py) Gateway (gateway/run.py) ACP (acp_adapter/) │ +│ CLI (cli.py) Gateway (gateway/run.py) ACP (hermes_agent/acp/)│ │ Batch Runner API Server Python Library │ └──────────┬──────────────┬───────────────────────┬───────────────────┘ │ │ │ @@ -122,7 +122,7 @@ hermes-agent/ │ # dingtalk, feishu, wecom, wecom_callback, weixin, │ # bluebubbles, qqbot, homeassistant, webhook, api_server │ -├── acp_adapter/ # ACP server (VS Code / Zed / JetBrains) +├── hermes_agent/acp/ # ACP server (VS Code / Zed / JetBrains) ├── cron/ # Scheduler (jobs.py, scheduler.py) ├── plugins/memory/ # Memory provider plugins ├── plugins/context_engine/ # Context engine plugins diff --git a/website/docs/reference/cli-commands.md b/website/docs/reference/cli-commands.md index ab1ecf526..05732fbe0 100644 --- a/website/docs/reference/cli-commands.md +++ b/website/docs/reference/cli-commands.md @@ -650,7 +650,7 @@ Related entrypoints: ```bash hermes-acp -python -m acp_adapter +python -m hermes_agent.acp ``` Install support first: diff --git a/website/docs/user-guide/features/acp.md b/website/docs/user-guide/features/acp.md index 3b1dce824..0e8785b4f 100644 --- a/website/docs/user-guide/features/acp.md +++ b/website/docs/user-guide/features/acp.md @@ -43,7 +43,7 @@ This installs the `agent-client-protocol` dependency and enables: - `hermes acp` - `hermes-acp` -- `python -m acp_adapter` +- `python -m hermes_agent.acp` ## Launching the ACP server @@ -58,7 +58,7 @@ hermes-acp ``` ```bash -python -m acp_adapter +python -m hermes_agent.acp ``` Hermes logs to stderr so stdout remains reserved for ACP JSON-RPC traffic.