mirrors/hermes-agent
1
0
Fork 0
mirror of https://github.com/NousResearch/hermes-agent.git synced 2026-07-09 13:21:42 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 6

fix(gateway): route plain-text approval responses instead of steering

Browse source 
When the agent is blocked waiting for a dangerous-command approval,
plain-text responses like "yes" or "approve" were being steered into
the running agent instead of being delivered to the approval handler.
This meant approval via messaging platforms (Signal, Telegram, etc.)
never succeeded — the user's response was consumed by the steer logic
and the approval timed out.

Add an early check in `_handle_active_session_busy_message` that routes
approval-like responses ("yes", "approve", "deny", etc.) to the
approval handler when `has_blocking_approval()` is true for the session.

Fixes #46866
This commit is contained in:
liuhao1024 2026-06-16 07:59:18 +08:00
parent 423d24780b
commit b37ec1e0fd
1 changed files with 34 additions and 0 deletions
Download patch file Download diff file Expand all files Collapse all files

34
gateway/run.py
View file

@ -3856,6 +3856,40 @@ class GatewayRunner(GatewayAuthorizationMixin, GatewayKanbanWatchersMixin, Gatew
)
return True
# --- Approval response routing (#46866) ---
# When the agent is blocked waiting for a dangerous-command approval,
# plain-text responses like "yes" or "approve" must be routed to the
# approval handler instead of being steered/queued/interrupted.
# Otherwise approval via messaging platforms never succeeds.
try:
from tools.approval import has_blocking_approval, resolve_gateway_approval
if has_blocking_approval(session_key):
_raw_text = (event.text or "").strip().lower()
_approval_choice = None
if _raw_text in {"approve", "yes", "ok", "confirm", "y"}:
_approval_choice = "once"
elif _raw_text in {"deny", "no", "reject", "n"}:
_approval_choice = "deny"
elif _raw_text in {"always", "approve always", "always approve"}:
_approval_choice = "always"
elif _raw_text in {"session", "approve session", "session approve"}:
_approval_choice = "session"
if _approval_choice is not None:
if _approval_choice == "deny":
resolve_gateway_approval(session_key, "deny")
else:
resolve_gateway_approval(session_key, _approval_choice)
_adapter = self.adapters.get(event.source.platform)
if _adapter:
_adapter.resume_typing_for_chat(event.source.chat_id)
logger.info(
"Approval response via plain text: session=%s choice=%s",
session_key, _approval_choice,
)
return True
except Exception:
pass # non-fatal — fall through to normal busy handling
# Normal busy case (agent actively running a task)
adapter = self.adapters.get(event.source.platform)
if not adapter: