From b2e6fdd3bfacae3ad54efb463260a8ed3578f3f7 Mon Sep 17 00:00:00 2001 From: sprmn24 Date: Fri, 22 May 2026 16:13:46 +0300 Subject: [PATCH] fix(agent): log warning when fallback model normalization fails instead of silently swallowing --- agent/chat_completion_helpers.py | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/agent/chat_completion_helpers.py b/agent/chat_completion_helpers.py index c68f2271f5b..f41e45cc820 100644 --- a/agent/chat_completion_helpers.py +++ b/agent/chat_completion_helpers.py @@ -776,8 +776,11 @@ def try_activate_fallback(agent, reason: "FailoverReason | None" = None) -> bool from hermes_cli.model_normalize import normalize_model_for_provider fb_model = normalize_model_for_provider(fb_model, fb_provider) - except Exception: - pass + except Exception as _norm_err: + logger.warning( + "Could not normalize fallback model %r for provider %r: %s", + fb_model, fb_provider, _norm_err, + ) # Determine api_mode from provider / base URL / model fb_api_mode = "chat_completions"