mirror of
https://github.com/NousResearch/hermes-agent.git
synced 2026-07-31 19:16:29 +00:00
feat(serve): add secure Desktop SSH bootstrap contract
Accept descriptor-safe one-shot token files and exact owner nonces, expose an authenticated ownership proof endpoint, and preserve the process-local contract across parser and server startup paths.
This commit is contained in:
parent
a340d0adc5
commit
ae2175a584
6 changed files with 282 additions and 0 deletions
86
tests/hermes_cli/test_ssh_session_token_parser.py
Normal file
86
tests/hermes_cli/test_ssh_session_token_parser.py
Normal file
|
|
@ -0,0 +1,86 @@
|
|||
import argparse
|
||||
import os
|
||||
|
||||
import pytest
|
||||
|
||||
from hermes_cli.main import _read_ssh_session_token_file, cmd_dashboard
|
||||
from hermes_cli.subcommands.dashboard import build_dashboard_parser
|
||||
|
||||
|
||||
def dashboard_parser():
|
||||
parser = argparse.ArgumentParser()
|
||||
subparsers = parser.add_subparsers(dest="command")
|
||||
build_dashboard_parser(
|
||||
subparsers,
|
||||
cmd_dashboard=lambda _args: None,
|
||||
cmd_dashboard_register=lambda _args: None,
|
||||
)
|
||||
return parser
|
||||
|
||||
|
||||
def test_serve_help_advertises_secure_ssh_bootstrap_flags(capsys):
|
||||
with pytest.raises(SystemExit) as exit_info:
|
||||
dashboard_parser().parse_args(["serve", "--help"])
|
||||
assert exit_info.value.code == 0
|
||||
output = capsys.readouterr().out
|
||||
assert "--ssh-session-token-file PATH" in output
|
||||
assert "--ssh-owner-nonce NONCE" in output
|
||||
|
||||
|
||||
def test_serve_accepts_owner_nonce():
|
||||
args = dashboard_parser().parse_args(["serve", "--ssh-owner-nonce", "0123456789abcdef"])
|
||||
assert args.ssh_owner_nonce == "0123456789abcdef"
|
||||
|
||||
|
||||
@pytest.mark.parametrize("operation", ["--status", "--stop"])
|
||||
def test_one_shot_token_file_rejects_non_starting_operations(operation):
|
||||
args = dashboard_parser().parse_args([
|
||||
"serve", operation, "--ssh-session-token-file", "/tmp/token",
|
||||
])
|
||||
with pytest.raises(SystemExit, match="cannot be used"):
|
||||
cmd_dashboard(args)
|
||||
|
||||
|
||||
def test_token_file_is_read_and_unlinked_through_private_directory(tmp_path, monkeypatch):
|
||||
home = tmp_path / "home"
|
||||
token_dir = home / ".hermes" / "desktop-ssh" / ("a" * 32)
|
||||
token_dir.mkdir(parents=True, mode=0o700)
|
||||
token_path = token_dir / "0123456789abcdef.token"
|
||||
token_path.write_text("b" * 64)
|
||||
token_path.chmod(0o600)
|
||||
monkeypatch.setattr("pathlib.Path.home", lambda: home)
|
||||
|
||||
assert _read_ssh_session_token_file(str(token_path)) == "b" * 64
|
||||
assert not token_path.exists()
|
||||
|
||||
|
||||
@pytest.mark.skipif(os.name == "nt", reason="POSIX symlink contract")
|
||||
def test_token_file_rejects_symlink(tmp_path, monkeypatch):
|
||||
home = tmp_path / "home"
|
||||
token_dir = home / ".hermes" / "desktop-ssh" / ("a" * 32)
|
||||
token_dir.mkdir(parents=True, mode=0o700)
|
||||
target = tmp_path / "token"
|
||||
target.write_text("b" * 64)
|
||||
target.chmod(0o600)
|
||||
token_path = token_dir / "0123456789abcdef.token"
|
||||
token_path.symlink_to(target)
|
||||
monkeypatch.setattr("pathlib.Path.home", lambda: home)
|
||||
|
||||
with pytest.raises(SystemExit, match="symlink|not accessible"):
|
||||
_read_ssh_session_token_file(str(token_path))
|
||||
assert not token_path.exists()
|
||||
assert target.read_text() == "b" * 64
|
||||
|
||||
|
||||
def test_token_file_rejects_parent_escape(tmp_path, monkeypatch):
|
||||
home = tmp_path / "home"
|
||||
token_root = home / ".hermes" / "desktop-ssh"
|
||||
token_root.mkdir(parents=True, mode=0o700)
|
||||
escaped = token_root.parent / "0123456789abcdef.token"
|
||||
escaped.write_text("b" * 64)
|
||||
escaped.chmod(0o600)
|
||||
monkeypatch.setattr("pathlib.Path.home", lambda: home)
|
||||
|
||||
with pytest.raises(SystemExit, match="invalid runtime path"):
|
||||
_read_ssh_session_token_file(str(token_root / ".." / escaped.name))
|
||||
assert escaped.exists()
|
||||
Loading…
Add table
Add a link
Reference in a new issue