From adb418fb5390d77b4516a7413cbc53b09717f1d5 Mon Sep 17 00:00:00 2001 From: Teknium Date: Mon, 6 Apr 2026 16:53:24 -0700 Subject: [PATCH] fix: cross-platform browser test path separators Use os.path.join for Windows install path so test passes on Linux (os.path.join uses / on Linux, \ on Windows). --- tests/test_cli_browser_connect.py | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/tests/test_cli_browser_connect.py b/tests/test_cli_browser_connect.py index a913d96fe5d..f01475bf8a9 100644 --- a/tests/test_cli_browser_connect.py +++ b/tests/test_cli_browser_connect.py @@ -1,5 +1,6 @@ """Tests for CLI browser CDP auto-launch helpers.""" +import os from unittest.mock import patch from cli import HermesCLI @@ -24,14 +25,16 @@ class TestChromeDebugLaunch: def test_windows_launch_falls_back_to_common_install_dirs(self, monkeypatch): captured = {} - installed = r"C:\Program Files\Google\Chrome\Application\chrome.exe" + program_files = r"C:\Program Files" + # Use os.path.join so path separators match cross-platform + installed = os.path.join(program_files, "Google", "Chrome", "Application", "chrome.exe") def fake_popen(cmd, **kwargs): captured["cmd"] = cmd captured["kwargs"] = kwargs return object() - monkeypatch.setenv("ProgramFiles", r"C:\Program Files") + monkeypatch.setenv("ProgramFiles", program_files) monkeypatch.delenv("ProgramFiles(x86)", raising=False) monkeypatch.delenv("LOCALAPPDATA", raising=False)