mirrors/hermes-agent
1
0
Fork 0
mirror of https://github.com/NousResearch/hermes-agent.git synced 2026-06-09 08:21:50 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 10

fix(desktop): cap desktop.log size to prevent unbounded growth

Browse source 
desktop.log is an append-only forensic log written via appendFileSync /
fs.promises.appendFile with no rotation. When the backend enters a boot
loop — e.g. the version-skew crash where an old app shell spawns
`dashboard --tui`, argparse exits(2) instantly, and the renderer keeps
retrying — the full bootstrap transcript plus repeated stack traces are
appended on every attempt. In the wild this drove a single desktop.log to
~326 GB, exhausting the disk and breaking `hermes update`/install (git
index.lock, venv rebuild, and npm all need scratch space).

Rotate to a single .1 sibling once the live file crosses a 10 MB cap, so
total on-disk usage stays ~2x the cap while preserving the most recent
transcript for diagnostics. The size check runs before each append in both
the sync (shutdown) and async (steady-state) flush paths. All filesystem
ops stay inside try/catch so logging can never block startup/shutdown or
crash the shell — consistent with the existing append error handling.

Paired with the CLI --tui back-compat guard in this PR: the guard stops the
crash loop from starting, and this stops a crash loop (from any cause) from
ever filling the disk.
This commit is contained in:
The Garden 2026-06-06 12:14:54 -05:00 • committed by brooklyn!
parent 2820d87ea5
commit abbf050241
1 changed files with 36 additions and 0 deletions
Download patch file Download diff file Expand all files Collapse all files

36
apps/desktop/electron/main.cjs
View file

@ -247,6 +247,16 @@ const DEFAULT_UPDATE_BRANCH = 'main'
const DESKTOP_LOG_PATH = path.join(HERMES_HOME, 'logs', 'desktop.log')
const DESKTOP_LOG_FLUSH_MS = 120
const DESKTOP_LOG_BUFFER_MAX_CHARS = 64 * 1024
// Cap desktop.log on disk. It is an append-only forensic log with no other
// rotation, so a boot loop (e.g. a version-skew crash where the backend exits
// instantly and the renderer keeps hitting Retry) appends the full bootstrap
// transcript on every attempt and can grow without bound — we have seen this
// file reach hundreds of GB and exhaust the disk, which then breaks update and
// install (no room for git/venv/npm temp files). Rotate to a single .1 sibling
// when the live file crosses the cap, so total on-disk usage stays ~2x the cap
// while preserving the most recent transcript for diagnostics.
const DESKTOP_LOG_MAX_BYTES = 10 * 1024 * 1024
const DESKTOP_LOG_ROTATED_PATH = `${DESKTOP_LOG_PATH}.1`
const BOOT_FAKE_MODE = process.env.HERMES_DESKTOP_BOOT_FAKE === '1'
const BOOT_FAKE_STEP_MS = (() => {
const raw = Number.parseInt(String(process.env.HERMES_DESKTOP_BOOT_FAKE_STEP_MS || ''), 10)
@ -534,6 +544,30 @@ let bootProgressState = {
timestamp: Date.now()
}
function rotateDesktopLogIfNeededSync() {
try {
const { size } = fs.statSync(DESKTOP_LOG_PATH)
if (size < DESKTOP_LOG_MAX_BYTES) return
fs.rmSync(DESKTOP_LOG_ROTATED_PATH, { force: true })
fs.renameSync(DESKTOP_LOG_PATH, DESKTOP_LOG_ROTATED_PATH)
} catch {
// No file yet (ENOENT) or rotation failed — appending will (re)create it.
// Logging must never block app startup/shutdown.
}
}
async function rotateDesktopLogIfNeededAsync() {
try {
const { size } = await fs.promises.stat(DESKTOP_LOG_PATH)
if (size < DESKTOP_LOG_MAX_BYTES) return
await fs.promises.rm(DESKTOP_LOG_ROTATED_PATH, { force: true })
await fs.promises.rename(DESKTOP_LOG_PATH, DESKTOP_LOG_ROTATED_PATH)
} catch {
// No file yet (ENOENT) or rotation failed — appending will (re)create it.
// Logging must never crash the desktop shell.
}
}
function flushDesktopLogBufferSync() {
if (!desktopLogBuffer) return
const chunk = desktopLogBuffer
@ -541,6 +575,7 @@ function flushDesktopLogBufferSync() {
try {
fs.mkdirSync(path.dirname(DESKTOP_LOG_PATH), { recursive: true })
rotateDesktopLogIfNeededSync()
fs.appendFileSync(DESKTOP_LOG_PATH, chunk)
} catch {
// Logging must never block app startup/shutdown.
@ -555,6 +590,7 @@ function flushDesktopLogBufferAsync() {
desktopLogFlushPromise = desktopLogFlushPromise
.then(async () => {
await fs.promises.mkdir(path.dirname(DESKTOP_LOG_PATH), { recursive: true })
await rotateDesktopLogIfNeededAsync()
await fs.promises.appendFile(DESKTOP_LOG_PATH, chunk)
})
.catch(() => {