mirrors/hermes-agent
1
0
Fork 0
mirror of https://github.com/NousResearch/hermes-agent.git synced 2026-07-01 12:02:05 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 4

fix: drop isinstance(str) guard so client.base_url fallback works with httpx.URL

Browse source 
The OpenAI SDK exposes client.base_url as an httpx.URL object, not str.
The isinstance(live_raw, str) guard made this branch dead code in
production. Use _normalized_runtime_url (which coerces via str()) so
the fallback actually fires.
This commit is contained in:
kshitijk4poor 2026-06-27 03:52:36 +05:30 • committed by kshitij
parent 2608f78b93
commit a67ddf5983
1 changed files with 9 additions and 9 deletions
Download patch file Download diff file Expand all files Collapse all files

18
tools/delegate_tool.py
View file

@ -1013,15 +1013,15 @@ def _inherit_parent_base_url(parent_agent, fallback_base_url: Optional[str]) ->
client = getattr(parent_agent, "client", None)
if client is not None:
live_raw = getattr(client, "base_url", "")
if isinstance(live_raw, str):
live_url = _normalized_runtime_url(live_raw)
if (
live_url
and live_url != surface_url
and live_url.startswith(("http://", "https://"))
):
return live_url
# OpenAI SDK exposes ``base_url`` as an ``httpx.URL``, not ``str`` —
# coerce so the comparison works regardless of the client's type.
live_url = _normalized_runtime_url(getattr(client, "base_url", ""))
if (
live_url
and live_url != surface_url
and live_url.startswith(("http://", "https://"))
):
return live_url
return fallback_base_url or None