mirrors/hermes-agent
1
0
Fork 0
mirror of https://github.com/NousResearch/hermes-agent.git synced 2026-05-30 06:41:51 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 15

feat(kanban): allow trimmed task comments

Browse source 
SS-1647 live SHIP validation: real code + tests for kanban comment --max-len.
This commit is contained in:
ACR27 2026-05-18 20:25:23 -07:00 • committed by Teknium
parent 5d079fee17
commit a5c2836b07
2 changed files with 21 additions and 2 deletions
Download patch file Download diff file Expand all files Collapse all files

9
hermes_cli/kanban.py
View file

@ -403,6 +403,8 @@ def build_parser(parent_subparsers: argparse._SubParsersAction) -> argparse.Argu
p_comment.add_argument("text", nargs="+", help="Comment body")
p_comment.add_argument("--author", default=None,
help="Author name (default: $HERMES_PROFILE or 'user')")
p_comment.add_argument("--max-len", type=int, default=None,
help="Trim the stored comment body to this many characters")
p_complete = sub.add_parser("complete", help="Mark one or more tasks done")
p_complete.add_argument("task_ids", nargs="+",
@ -1616,6 +1618,13 @@ def _cmd_claim(args: argparse.Namespace) -> int:
def _cmd_comment(args: argparse.Namespace) -> int:
body = " ".join(args.text).strip()
if args.max_len is not None:
if args.max_len < 1:
print("kanban: --max-len must be positive", file=sys.stderr)
return 2
if len(body) > args.max_len:
suffix = f"\n\n[trimmed to {args.max_len} chars by --max-len]"
body = body[: max(0, args.max_len - len(suffix))].rstrip() + suffix
author = args.author or _profile_author()
with kb.connect() as conn:
kb.add_comment(conn, args.task_id, author, body)

14
tests/hermes_cli/test_kanban_cli.py
View file

@ -96,9 +96,19 @@ def test_run_slash_show_includes_comments(kanban_home):
out = kc.run_slash("create 'x'")
import re
tid = re.search(r"(t_[a-f0-9]+)", out).group(1)
kc.run_slash(f"comment {tid} 'source is paywalled'")
kc.run_slash(f"comment {tid} 'remember to include performance section'")
show = kc.run_slash(f"show {tid}")
assert "source is paywalled" in show
assert "performance section" in show
def test_run_slash_comment_max_len_trims_long_body(kanban_home):
out = kc.run_slash("create 'x'")
import re
tid = re.search(r"(t_[a-f0-9]+)", out).group(1)
kc.run_slash(f"comment {tid} '{'x' * 30}' --max-len 20")
show = kc.run_slash(f"show {tid}")
assert "trimmed to 20 chars by --max-len" in show
assert "x" * 30 not in show
def test_run_slash_block_unblock_cycle(kanban_home):