fix(dashboard): skill installs from the dashboard silently auto-cancel (#45150)

The dashboard's /api/skills/hub/install (and the new-profile hub_skills
path) spawned `hermes skills install <id>` with stdin=DEVNULL but
without --yes. do_install()'s 'Confirm [y/N]' prompt hit EOF, defaulted
to 'n', and printed 'Installation cancelled.' into a background log the
user never sees — every dashboard install no-opped.

Pass --yes on both spawn sites, matching the uninstall endpoint which
already passed --yes. The dashboard install button is the explicit user
consent, same as the TUI/slash-command skip_confirm rationale.

Repro: spawned the exact argv with stdin=DEVNULL against a temp
HERMES_HOME — without --yes it cancels, with --yes the skill installs.
This commit is contained in:
Teknium 2026-06-12 12:58:36 -07:00 committed by GitHub
parent bba9b519aa
commit a118b94a85
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
3 changed files with 14 additions and 5 deletions

View file

@ -8105,7 +8105,8 @@ async def install_skill_hub(body: SkillInstallRequest, profile: Optional[str] =
raise HTTPException(status_code=400, detail="identifier is required")
try:
proc = _spawn_hermes_action(
_profile_cli_args(body.profile or profile) + ["skills", "install", identifier],
_profile_cli_args(body.profile or profile)
+ ["skills", "install", identifier, "--yes"],
"skills-install",
)
except HTTPException:
@ -8843,7 +8844,7 @@ async def create_profile_endpoint(body: ProfileCreate):
continue
try:
proc = _spawn_hermes_action(
["-p", body.name, "skills", "install", ident],
["-p", body.name, "skills", "install", ident, "--yes"],
"skills-install",
)
hub_installs.append({"identifier": ident, "pid": proc.pid})

View file

@ -2690,7 +2690,12 @@ class TestNewEndpoints:
assert data["hub_installs"] == [{"identifier": "someuser/some-skill", "pid": 4321}]
# Hub install was scoped to the new profile.
assert spawned == [(["-p", "builder", "skills", "install", "someuser/some-skill"], "skills-install")]
assert spawned == [
(
["-p", "builder", "skills", "install", "someuser/some-skill", "--yes"],
"skills-install",
)
]
# Verify the writes landed in the NEW profile's config, not the root.
prof_dir = get_hermes_home() / "profiles" / "builder"

View file

@ -178,7 +178,10 @@ class TestProfileScopedHubActions:
)
assert resp.status_code == 200
assert calls == [
(["-p", "worker_alpha", "skills", "install", "official/demo"], "skills-install")
(
["-p", "worker_alpha", "skills", "install", "official/demo", "--yes"],
"skills-install",
)
]
def test_hub_install_without_profile_keeps_legacy_argv(
@ -200,7 +203,7 @@ class TestProfileScopedHubActions:
"/api/skills/hub/install", json={"identifier": "official/demo"}
)
assert resp.status_code == 200
assert calls == [["skills", "install", "official/demo"]]
assert calls == [["skills", "install", "official/demo", "--yes"]]
def test_hub_install_unknown_profile_404(self, client, isolated_profiles):
resp = client.post(