mirrors/hermes-agent
1
0
Fork 0
mirror of https://github.com/NousResearch/hermes-agent.git synced 2026-07-19 15:18:03 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 5

fix(agent): preserve none vs unknown tool effects (#61783)

Browse source 
* fix(agent): persist truthful tool effect dispositions

* fix(agent): preserve successful siblings during orphan recovery

* fix(agent): narrow effect dispositions to none and unknown
This commit is contained in:
Teknium 2026-07-11 05:41:58 -07:00 • committed by GitHub
parent 5ecc07986f
commit a0a6cd80f5
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
13 changed files with 253 additions and 38 deletions
Download patch file Download diff file Expand all files Collapse all files

15
tests/agent/test_tool_result_classification.py
View file

@ -2,7 +2,9 @@
import json
from agent.tool_result_classification import file_mutation_result_landed
from agent.tool_result_classification import (
file_mutation_result_landed,
)
def test_write_file_with_nested_lint_error_counts_as_landed():
@ -28,3 +30,14 @@ def test_top_level_file_mutation_error_does_not_count_as_landed():
result = json.dumps({"success": True, "error": "post-write verification failed"})
assert file_mutation_result_landed("patch", result) is False
def test_side_effect_classification_keeps_session_mutations():
from agent.tool_result_classification import tool_may_have_side_effect
assert tool_may_have_side_effect("todo") is True
assert tool_may_have_side_effect("memory") is True
assert tool_may_have_side_effect("write_file") is True
assert tool_may_have_side_effect("mcp_unknown") is True
assert tool_may_have_side_effect("read_file") is False
assert tool_may_have_side_effect("web_search") is False