mirrors/hermes-agent
1
0
Fork 0
mirror of https://github.com/NousResearch/hermes-agent.git synced 2026-07-15 14:22:43 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 5

test(gateway): pin in-place compaction skipping the destructive rewrite

Browse source 
Flip the two tests that pinned the old buggy behavior (rewrite_transcript
called after in-place compaction) to assert the corrected invariant from
#61145: archive_and_compact() already persisted, so the handler must NOT
call rewrite_transcript — its replace_messages(active_only=False) would
DELETE the just-archived rows.

E2E-verified against a real SessionDB: 6 soft-archived rows are wiped by
replace_messages' default path, confirming the data-loss premise.
This commit is contained in:
teknium1 2026-07-09 16:52:36 -07:00 • committed by Teknium
parent 549b87c9aa
commit 9cbac6418b
2 changed files with 22 additions and 13 deletions
Download patch file Download diff file Expand all files Collapse all files

28
tests/gateway/test_compress_command.py
View file

@ -369,11 +369,14 @@ async def test_compress_command_does_not_repoint_session_when_transcript_write_f
@pytest.mark.asyncio
async def test_compress_command_in_place_write_failure_reports_error():
"""In-place compaction (compression.in_place / #38763) does not rotate the
session_id, so a failed rewrite_transcript would leave the DB untouched
while the handler reported success. The write failure must surface as a
failure banner, not a false "Compressed" success."""
async def test_compress_command_in_place_skips_destructive_rewrite():
"""In-place compaction (compression.in_place / #38763) persists via
archive_and_compact() inside _compress_context — the previous active rows
are soft-archived and the compacted set inserted. Calling
rewrite_transcript() afterwards would invoke
replace_messages(active_only=False), DELETEing the just-archived rows
(silent data loss, #61145). The handler must skip the rewrite and still
report success."""
history = _make_history()
compressed = [
history[0],
@ -383,7 +386,7 @@ async def test_compress_command_in_place_write_failure_reports_error():
runner = _make_runner(history)
runner._session_db = object()
session_entry = runner.session_store.get_or_create_session.return_value
runner.session_store.rewrite_transcript = MagicMock(return_value=False)
runner.session_store.rewrite_transcript = MagicMock()
agent_instance = MagicMock()
agent_instance.shutdown_memory_provider = MagicMock()
@ -397,7 +400,11 @@ async def test_compress_command_in_place_write_failure_reports_error():
agent_instance._compress_context.return_value = (compressed, "")
def _estimate(messages, **_kwargs):
return 100
if messages == history:
return 100
if messages == compressed:
return 60
raise AssertionError(f"unexpected transcript: {messages!r}")
with (
patch("gateway.run._resolve_runtime_agent_kwargs", return_value={"api_key": "***"}),
@ -407,10 +414,11 @@ async def test_compress_command_in_place_write_failure_reports_error():
):
result = await runner._handle_compress_command(_make_event())
assert "failed" in result.lower()
assert "Compressed:" not in result
assert "Compressed:" in result
# The destructive rewrite must NOT run — archive_and_compact() already
# persisted, and rewrite_transcript would wipe the archived rows.
runner.session_store.rewrite_transcript.assert_not_called()
assert session_entry.session_id == "sess-1"
runner.session_store._save.assert_not_called()
agent_instance.shutdown_memory_provider.assert_called_once()
agent_instance.close.assert_called_once()

7
tests/gateway/test_session_hygiene.py
View file

@ -950,9 +950,10 @@ async def test_session_hygiene_forces_in_place_compaction_with_bound_session_db(
agent = FakeInPlaceCompressAgent.last_instance
assert agent is not None
agent.context_compressor.bind_session_state.assert_called_once_with(fake_db, "sess-1")
runner.session_store.rewrite_transcript.assert_called_once_with(
"sess-1", [{"role": "assistant", "content": "compressed in place"}]
)
# In-place compaction already persisted via archive_and_compact() —
# rewrite_transcript would replace_messages(active_only=False) and DELETE
# the just-archived rows (#61145). The hygiene handler must skip it.
runner.session_store.rewrite_transcript.assert_not_called()
runner._run_agent.assert_awaited_once()