From 99a20f8d9ab35118ddf6ced4a06905f848131b83 Mon Sep 17 00:00:00 2001 From: Hao Zhe Date: Wed, 17 Jun 2026 15:05:51 +0800 Subject: [PATCH] test(openviking): update plugin expectations --- tests/openviking_plugin/test_openviking.py | 30 ++++++++++++++-------- 1 file changed, 20 insertions(+), 10 deletions(-) diff --git a/tests/openviking_plugin/test_openviking.py b/tests/openviking_plugin/test_openviking.py index 1c3365b9c02..6007d875373 100644 --- a/tests/openviking_plugin/test_openviking.py +++ b/tests/openviking_plugin/test_openviking.py @@ -148,7 +148,7 @@ class TestOpenVikingSkillQuerySafety: assert RecordingVikingClient.calls == [ ( "/api/v1/search/find", - {"query": "make a skill for release triage", "top_k": 5}, + {"query": "make a skill for release triage", "limit": 5}, ) ] @@ -178,7 +178,7 @@ class TestOpenVikingSkillQuerySafety: assert RecordingVikingClient.calls == [ ( "/api/v1/search/find", - {"query": "fix the failing retrieval test", "top_k": 5}, + {"query": "fix the failing retrieval test", "limit": 5}, ) ] @@ -220,16 +220,25 @@ class TestOpenVikingSkillQuerySafety: ) provider.sync_turn(skill_message, "Done.") - provider._sync_thread.join(timeout=5.0) + assert provider._drain_writers("session-1", timeout=5.0) assert RecordingVikingClient.calls == [ ( - "/api/v1/sessions/session-1/messages", - {"role": "user", "content": "make a skill for release triage"}, - ), - ( - "/api/v1/sessions/session-1/messages", - {"role": "assistant", "content": "Done."}, + "/api/v1/sessions/session-1/messages/batch", + { + "messages": [ + { + "role": "user", + "parts": [ + {"type": "text", "text": "make a skill for release triage"}, + ], + }, + { + "role": "assistant", + "parts": [{"type": "text", "text": "Done."}], + }, + ] + }, ), ] @@ -247,7 +256,8 @@ class TestOpenVikingSkillQuerySafety: provider.sync_turn(skill_message, "Done.") - assert provider._sync_thread is None + assert provider._turn_count == 0 + assert provider._inflight_writers == {} assert RecordingVikingClient.calls == []