From 92a567db2d7a5031df8211efbfdad864c2f51faf Mon Sep 17 00:00:00 2001 From: Teknium <127238744+teknium1@users.noreply.github.com> Date: Mon, 1 Jun 2026 01:39:03 -0700 Subject: [PATCH] fix(ci): regen model catalog + stop gui tests consuming macos-fixup subprocess calls (#36687) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Two pre-existing failures on main, unrelated to each other: - test_model_catalog: website/static/api/model-catalog.json was stale vs _PROVIDER_MODELS — minimax/minimax-m2.7 was renamed to minimax/minimax-m3 without regenerating the committed manifest. Ran scripts/build_model_catalog.py. - test_gui_command: the macOS relaunchable-signing fixup (_desktop_macos_relaunchable_fixup) makes two subprocess.run calls (xattr + codesign) on darwin before launch. The two darwin GUI tests set sys.platform='darwin' and mock subprocess.run with a 2-element side_effect (pack + launch), so the fixup's calls drained the iterator -> StopIteration. Mock out the fixup in those two tests so the subprocess accounting stays focused on pack/launch. --- tests/hermes_cli/test_gui_command.py | 2 ++ website/static/api/model-catalog.json | 6 +++--- 2 files changed, 5 insertions(+), 3 deletions(-) diff --git a/tests/hermes_cli/test_gui_command.py b/tests/hermes_cli/test_gui_command.py index 963e4563b2b..b10a1701c7f 100644 --- a/tests/hermes_cli/test_gui_command.py +++ b/tests/hermes_cli/test_gui_command.py @@ -60,6 +60,7 @@ def test_gui_installs_packages_and_launches_desktop_app(tmp_path, monkeypatch): with patch("hermes_cli.main.shutil.which", return_value="/usr/bin/npm"), \ patch("hermes_cli.main._run_npm_install_deterministic", return_value=install_ok) as mock_install, \ + patch("hermes_cli.main._desktop_macos_relaunchable_fixup"), \ patch("hermes_cli.main.subprocess.run", side_effect=[pack_ok, launch_ok]) as mock_run, \ pytest.raises(SystemExit) as exc: cli_main.cmd_gui(_ns()) @@ -85,6 +86,7 @@ def test_gui_forwards_desktop_environment_overrides(tmp_path, monkeypatch): with patch("hermes_cli.main.shutil.which", return_value="/usr/bin/npm"), \ patch("hermes_cli.main._run_npm_install_deterministic", return_value=ok), \ + patch("hermes_cli.main._desktop_macos_relaunchable_fixup"), \ patch("hermes_cli.main.subprocess.run", side_effect=[ok, ok]) as mock_run, \ pytest.raises(SystemExit): cli_main.cmd_gui(_ns( diff --git a/website/static/api/model-catalog.json b/website/static/api/model-catalog.json index c2b7c241ab1..8cf88bc5c9c 100644 --- a/website/static/api/model-catalog.json +++ b/website/static/api/model-catalog.json @@ -1,6 +1,6 @@ { "version": 1, - "updated_at": "2026-05-31T03:27:32Z", + "updated_at": "2026-06-01T08:20:18Z", "metadata": { "source": "hermes-agent repo", "docs": "https://hermes-agent.nousresearch.com/docs/reference/model-catalog" @@ -77,7 +77,7 @@ "description": "recommended" }, { - "id": "minimax/minimax-m2.7", + "id": "minimax/minimax-m3", "description": "" }, { @@ -178,7 +178,7 @@ "id": "moonshotai/kimi-k2.6" }, { - "id": "minimax/minimax-m2.7" + "id": "minimax/minimax-m3" }, { "id": "z-ai/glm-5.1"