From 901165b5a46c5d1cb97d2b748d03e83371ce81ca Mon Sep 17 00:00:00 2001 From: teknium1 <127238744+teknium1@users.noreply.github.com> Date: Tue, 23 Jun 2026 22:32:14 -0700 Subject: [PATCH] fix(cron): complete plugins.cron_providers rename in 2 missed test files MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit uperLu's #50958 renamed plugins/cron → plugins/cron_providers but left two test files patching the now-gone plugins.cron.chronos.verify path, which would fail collection. Point them at plugins.cron_providers.*. Add uperLu to release.py AUTHOR_MAP. --- scripts/release.py | 1 + tests/gateway/test_cron_fire_webhook.py | 8 ++++---- tests/hermes_cli/test_cron_fire_dashboard.py | 8 ++++---- 3 files changed, 9 insertions(+), 8 deletions(-) diff --git a/scripts/release.py b/scripts/release.py index 09116194902..967740a25a2 100755 --- a/scripts/release.py +++ b/scripts/release.py @@ -46,6 +46,7 @@ ACP_REGISTRY_MANIFEST = REPO_ROOT / "acp_registry" / "agent.json" # Auto-extracted from noreply emails + manual overrides AUTHOR_MAP = { "145739220+wgu9@users.noreply.github.com": "wgu9", # PR #51468 salvage (WSL/no-systemd orphan gateway tracking, #51325) + "165020384+uperLu@users.noreply.github.com": "uperLu", # PR #50958 salvage (rename plugins/cron → plugins/cron_providers; #50872) "minz0721@outlook.com": "s010mn", # PR #29221 salvage (ollama-cloud reasoning_effort xhigh→max) "jeevesassistant00@gmail.com": "jeeves-assistant", # PR #50771 (computer-use CuaDriver vision capture routing) "21178861+ScotterMonk@users.noreply.github.com": "ScotterMonk", # PR #50145 salvage (cron output truncation: adapter-aware chunking, #50126) diff --git a/tests/gateway/test_cron_fire_webhook.py b/tests/gateway/test_cron_fire_webhook.py index e4aef243526..06eaba671da 100644 --- a/tests/gateway/test_cron_fire_webhook.py +++ b/tests/gateway/test_cron_fire_webhook.py @@ -53,7 +53,7 @@ async def test_valid_token_accepts_and_fires(adapter, monkeypatch): monkeypatch.setattr("cron.scheduler_provider.resolve_cron_scheduler", lambda: spy) # verifier returns claims (valid token) monkeypatch.setattr( - "plugins.cron.chronos.verify.get_fire_verifier", + "plugins.cron_providers.chronos.verify.get_fire_verifier", lambda: (lambda **kw: {"purpose": "cron_fire", "aud": "agent:x"}), ) @@ -80,7 +80,7 @@ async def test_invalid_token_401_and_no_fire(adapter, monkeypatch): spy = _SpyProvider() monkeypatch.setattr("cron.scheduler_provider.resolve_cron_scheduler", lambda: spy) monkeypatch.setattr( - "plugins.cron.chronos.verify.get_fire_verifier", + "plugins.cron_providers.chronos.verify.get_fire_verifier", lambda: (lambda **kw: None), # verification fails ) @@ -114,7 +114,7 @@ async def test_missing_job_id_400(adapter, monkeypatch): spy = _SpyProvider() monkeypatch.setattr("cron.scheduler_provider.resolve_cron_scheduler", lambda: spy) monkeypatch.setattr( - "plugins.cron.chronos.verify.get_fire_verifier", + "plugins.cron_providers.chronos.verify.get_fire_verifier", lambda: (lambda **kw: {"purpose": "cron_fire"}), ) @@ -134,7 +134,7 @@ async def test_fire_does_not_require_api_server_key(adapter, monkeypatch): spy = _SpyProvider() monkeypatch.setattr("cron.scheduler_provider.resolve_cron_scheduler", lambda: spy) monkeypatch.setattr( - "plugins.cron.chronos.verify.get_fire_verifier", + "plugins.cron_providers.chronos.verify.get_fire_verifier", lambda: (lambda **kw: {"purpose": "cron_fire"}), ) diff --git a/tests/hermes_cli/test_cron_fire_dashboard.py b/tests/hermes_cli/test_cron_fire_dashboard.py index 44d6f07c270..8a49d5f9fe8 100644 --- a/tests/hermes_cli/test_cron_fire_dashboard.py +++ b/tests/hermes_cli/test_cron_fire_dashboard.py @@ -61,7 +61,7 @@ def test_bad_token_401(monkeypatch): gate). fire_due must NOT run.""" fired = [] monkeypatch.setattr( - "plugins.cron.chronos.verify.get_fire_verifier", + "plugins.cron_providers.chronos.verify.get_fire_verifier", lambda: (lambda **kw: None), # verification fails ) monkeypatch.setattr(web_server, "_find_cron_job_profile", lambda jid: "default") @@ -82,7 +82,7 @@ def test_bad_token_401(monkeypatch): def test_missing_job_id_400(monkeypatch): monkeypatch.setattr( - "plugins.cron.chronos.verify.get_fire_verifier", + "plugins.cron_providers.chronos.verify.get_fire_verifier", lambda: (lambda **kw: {"purpose": "cron_fire"}), ) client, pa, ph = _client(auth_required=False) @@ -100,7 +100,7 @@ def test_unknown_job_200_gone(monkeypatch): """Valid token but the job isn't found in any profile -> 200 'gone' (NAS shouldn't retry a fire for a cancelled/completed job).""" monkeypatch.setattr( - "plugins.cron.chronos.verify.get_fire_verifier", + "plugins.cron_providers.chronos.verify.get_fire_verifier", lambda: (lambda **kw: {"purpose": "cron_fire"}), ) monkeypatch.setattr(web_server, "_find_cron_job_profile", lambda jid: None) @@ -121,7 +121,7 @@ def test_valid_token_accepts_and_fires(monkeypatch): profile.""" fired = [] monkeypatch.setattr( - "plugins.cron.chronos.verify.get_fire_verifier", + "plugins.cron_providers.chronos.verify.get_fire_verifier", lambda: (lambda **kw: {"purpose": "cron_fire", "aud": "agent:x"}), ) monkeypatch.setattr(web_server, "_find_cron_job_profile", lambda jid: "default")