mirrors/hermes-agent
1
0
Fork 0
mirror of https://github.com/NousResearch/hermes-agent.git synced 2026-04-25 00:51:20 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions

fix: remove OpenRouter '/' format enforcement — let API probe be the authority

Browse source 
Not all providers require 'provider/model' format. Removing the rigid
format check lets the live API probe handle all validation uniformly.
If someone types 'gpt-5.4' on OpenRouter, the probe won't find it and
will suggest 'openai/gpt-5.4' — better UX than a format rejection.
This commit is contained in:
teknium1 2026-03-08 05:31:41 -07:00
parent 245d174359
commit 8c734f2f27
3 changed files with 15 additions and 32 deletions
Download patch file Download diff file Expand all files Collapse all files

18
tests/hermes_cli/test_model_validation.py
View file

@ -103,18 +103,16 @@ class TestValidateFormatChecks:
assert result["accepted"] is False
assert "spaces" in result["message"].lower()
def test_openrouter_requires_slash(self):
result = _validate("claude-opus-4.6")
assert result["accepted"] is False
assert "provider/model" in result["message"]
def test_no_slash_model_still_probes_api(self):
"""Models without '/' should still be checked via API (not all providers need it)."""
result = _validate("gpt-5.4", api_models=["gpt-5.4", "gpt-5.4-pro"])
assert result["accepted"] is True
assert result["persist"] is True
def test_openrouter_rejects_leading_slash(self):
result = _validate("/claude-opus-4.6")
assert result["accepted"] is False
def test_openrouter_rejects_trailing_slash(self):
result = _validate("anthropic/")
def test_no_slash_model_rejected_if_not_in_api(self):
result = _validate("gpt-5.4", api_models=["openai/gpt-5.4"])
assert result["accepted"] is False
assert "not a valid model" in result["message"]
# -- validate_requested_model — API probe found model ------------------------