From 88564ad8bc7518f2c67bbbc63b758adcac5f8dca Mon Sep 17 00:00:00 2001 From: Teknium Date: Wed, 22 Apr 2026 06:14:08 -0700 Subject: [PATCH] fix(skins): don't inherit status_bar_* into light-mode skins MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit The salvaged status-bar skin keys were seeded on the default skin, but _build_skin_config merges default.colors into every skin — so daylight and warm-lightmode silently inherited silver status_bar_text (#C0C0C0) on their light backgrounds, rendering as low-contrast gray on gray. Drop the seven status_bar_{text,strong,dim,good,warn,bad,critical} entries from the default skin's colors and let get_prompt_toolkit_style _overrides fall back to banner_text / banner_title / banner_dim / ui_ok / ui_warn / ui_error. Dark skins keep their explicit overrides and render identically; light skins now inherit their own dark banner colors for readable status-bar text. --- hermes_cli/skin_engine.py | 7 ------- 1 file changed, 7 deletions(-) diff --git a/hermes_cli/skin_engine.py b/hermes_cli/skin_engine.py index 9f8b38c09..5619e7405 100644 --- a/hermes_cli/skin_engine.py +++ b/hermes_cli/skin_engine.py @@ -179,13 +179,6 @@ _BUILTIN_SKINS: Dict[str, Dict[str, Any]] = { "input_rule": "#CD7F32", "response_border": "#FFD700", "status_bar_bg": "#1a1a2e", - "status_bar_text": "#C0C0C0", - "status_bar_strong": "#FFD700", - "status_bar_dim": "#8B8682", - "status_bar_good": "#8FBC8F", - "status_bar_warn": "#FFD700", - "status_bar_bad": "#FF8C00", - "status_bar_critical": "#FF6B6B", "session_label": "#DAA520", "session_border": "#8B8682", },