mirrors/hermes-agent
1
0
Fork 0
mirror of https://github.com/NousResearch/hermes-agent.git synced 2026-07-11 13:41:53 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 5

fix(update): harden #57659 follow-ups — task restore on failure, --force-venv split, trampoline detection, managed-install health (#57680)

Browse source 
Five follow-ups to #57659 from post-merge review:

1. install.ps1: gateway scheduled-task re-enable now runs in a finally
   (a thrown Remove-Item/uv venv failure previously stranded the user's
   gateway autostart disabled), and tasks that were already disabled
   before the install are no longer blindly re-enabled.
2. The venv-python holder guard is no longer bypassed by plain --force
   (which the desktop bootstrap passes on every update while its lock
   probe only checks hermes.exe/app.asar). New explicit --force-venv is
   the escape hatch; --force keeps bypassing only the hermes.exe shim
   guard.
3. _detect_venv_python_processes now also catches uv/base-interpreter
   trampolines whose exe is outside the venv, via cmdline (venv path or
   '-m hermes_cli.main' tied to this install root) and cwd.
4. Missing venv python is now UNHEALTHY on managed installs
   (.hermes-bootstrap-complete / .update-incomplete markers) so the
   repair lane runs instead of 'Already up to date!'; the repair branch
   recreates the venv first when it's gone entirely. Dev checkouts keep
   reporting healthy.
5. install.ps1 comment no longer claims a Startup-folder disarm the
   code doesn't perform (logon-only, not a mid-install respawner).
This commit is contained in:
Teknium 2026-07-03 04:08:37 -07:00 • committed by GitHub
parent 0e9136cb27
commit 87ae4ae94b
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
6 changed files with 278 additions and 36 deletions
Download patch file Download diff file Expand all files Collapse all files

57
scripts/install.ps1
View file

@ -1602,7 +1602,12 @@ function Install-Venv {
Write-Info "Creating virtual environment with Python $PythonVersion..."
Push-Location $InstallDir
# Tasks we disabled below and must re-enable no matter how this stage
# exits. Populated only with tasks that were ENABLED before we touched
# them, so a task the user deliberately disabled is never re-armed.
$gatewayTasksDisabled = @()
try {
if (Test-Path "venv") {
Write-Info "Virtual environment already exists, recreating..."
# On Windows, native Python extensions (e.g. _bcrypt.pyd, tornado's
@ -1614,18 +1619,23 @@ function Install-Venv {
if ($env:OS -eq "Windows_NT") {
$myPid = $PID
Write-Info "Stopping any running hermes processes before recreating venv..."
# Disarm respawners FIRST: the gateway autostart Scheduled Task and
# the Startup-folder entry both relaunch a killed gateway within
# seconds, and losing that race re-locks the venv's .pyd files
# between our kill sweep and Remove-Item (the July 2026
# _brotlicffi.pyd incident). schtasks /End stops a running task
# instance; /Change /DISABLE stops it from re-firing mid-install.
# Re-enabled after the venv is recreated (below). Best-effort: a
# missing task just errors quietly.
$gatewayTasksDisabled = @()
# Disarm the respawner FIRST: the gateway autostart Scheduled Task
# relaunches a killed gateway within seconds, and losing that race
# re-locks the venv's .pyd files between our kill sweep and
# Remove-Item (the July 2026 _brotlicffi.pyd incident). schtasks
# /End stops a running task instance; /Change /DISABLE stops it
# from re-firing mid-install. (The Startup-folder .vbs fallback is
# NOT touched: it only fires at logon, so it cannot respawn a
# gateway mid-install.) Re-enabled in the finally below — including
# on failure — but only for tasks that were enabled to begin with.
# Best-effort: a missing task just errors quietly.
try {
schtasks /Query /FO CSV 2>$null | ConvertFrom-Csv | Where-Object { $_.TaskName -like '*Hermes_Gateway*' } | ForEach-Object {
$tn = $_.TaskName
if ($_.Status -eq 'Disabled') {
Write-Info " gateway autostart task $tn is already disabled; leaving it that way"
return
}
schtasks /End /TN $tn 2>$null | Out-Null
schtasks /Change /TN $tn /DISABLE 2>$null | Out-Null
$gatewayTasksDisabled += $tn
@ -1727,7 +1737,6 @@ function Install-Venv {
# ok=true) when the venv was never created.
$venvExitCode = $LASTEXITCODE
if ($venvExitCode -ne 0) {
Pop-Location
throw "Failed to create virtual environment (uv venv exited with $venvExitCode)"
}
@ -1742,19 +1751,21 @@ function Install-Venv {
if (Test-Path $venvPythonExe) {
$env:UV_PYTHON = $venvPythonExe
}
Pop-Location
# Re-arm the gateway autostart tasks disabled during the venv teardown.
# Same function scope, so the list survives even under the stage-per-
# process bootstrap. Deliberately NOT started here — dependencies aren't
# installed yet; the task fires normally on next logon and `hermes update`
# / the gateway resume path handles the immediate restart.
if ($gatewayTasksDisabled -and $gatewayTasksDisabled.Count -gt 0) {
foreach ($tn in $gatewayTasksDisabled) {
schtasks /Change /TN $tn /ENABLE 2>$null | Out-Null
} finally {
Pop-Location
# Re-arm the gateway autostart tasks disabled during the venv teardown
# — in a finally so a failed teardown/creation can never strand the
# user's gateway autostart in the disabled state. Same function scope,
# so the list survives even under the stage-per-process bootstrap.
# Deliberately NOT started here — dependencies aren't installed yet;
# the task fires normally on next logon and `hermes update` / the
# gateway resume path handles the immediate restart.
if ($gatewayTasksDisabled -and $gatewayTasksDisabled.Count -gt 0) {
foreach ($tn in $gatewayTasksDisabled) {
schtasks /Change /TN $tn /ENABLE 2>$null | Out-Null
}
Write-Info "Re-enabled gateway autostart task(s): $($gatewayTasksDisabled -join ', ')"
}
Write-Info "Re-enabled gateway autostart task(s): $($gatewayTasksDisabled -join ', ')"
}
Write-Success "Virtual environment ready (Python $PythonVersion)"