mirrors/hermes-agent
1
0
Fork 0
mirror of https://github.com/NousResearch/hermes-agent.git synced 2026-06-21 10:22:18 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 8

fix(dashboard): accept Slack allow-all wildcard in allowed-users validation

Browse source 
The new SLACK_ALLOWED_USERS validation rejected '*', but the Slack gateway
honors '*' as an allow-all wildcard (gateway/platforms/slack.py DM auth,
slash-confirm, and approval-button paths). Accept '*' as a valid list entry
in both the API validator and the dashboard form so a value the runtime
honors is no longer blocked at setup.
This commit is contained in:
kshitijk4poor 2026-06-19 12:18:15 +05:30
parent d9190491a6
commit 83c034bd5b
3 changed files with 17 additions and 2 deletions
Download patch file Download diff file Expand all files Collapse all files

4
hermes_cli/web_server.py
View file

@ -2342,10 +2342,12 @@ def _validate_messaging_env_value(platform_id: str, key: str, value: str) -> Non
)
if key == "SLACK_ALLOWED_USERS":
user_ids = [part.strip() for part in value.split(",")]
# "*" is the gateway's allow-all wildcard (see gateway/platforms/slack.py),
# so accept it as a valid entry alongside Slack member IDs (U.../W...).
invalid = [
user_id
for user_id in user_ids
if not user_id or not re.fullmatch(r"[UW][A-Z0-9]{2,}", user_id)
if user_id != "*" and (not user_id or not re.fullmatch(r"[UW][A-Z0-9]{2,}", user_id))
]
if invalid:
raise HTTPException(

13
tests/hermes_cli/test_web_server.py
View file

@ -1687,6 +1687,19 @@ class TestWebServerEndpoints:
assert resp.status_code == 400
assert "member IDs" in resp.json()["detail"]
def test_update_messaging_platform_accepts_slack_allowed_users_wildcard(self):
# "*" is the gateway's allow-all wildcard (gateway/platforms/slack.py),
# so the dashboard must accept it rather than rejecting it as malformed.
from hermes_cli.config import load_env
resp = self.client.put(
"/api/messaging/platforms/slack",
json={"env": {"SLACK_ALLOWED_USERS": "*"}},
)
assert resp.status_code == 200
assert load_env()["SLACK_ALLOWED_USERS"] == "*"
def test_messaging_platform_test_reports_missing_required_setup(self):
resp = self.client.put("/api/messaging/platforms/discord", json={"enabled": True})
assert resp.status_code == 200

2
web/src/pages/ChannelsPage.tsx
View file

@ -76,7 +76,7 @@ function validateMessagingEnvField(field: MessagingPlatformEnvVar, value: string
if (parts.some((part) => !part)) {
return "Slack member IDs must be comma-separated without empty entries.";
}
const invalid = parts.find((part) => !SLACK_MEMBER_ID_RE.test(part));
const invalid = parts.find((part) => part !== "*" && !SLACK_MEMBER_ID_RE.test(part));
if (invalid) {
return `${invalid} does not look like a Slack member ID. Use IDs like U01ABC2DEF3.`;
}