mirrors/hermes-agent
1
0
Fork 0
mirror of https://github.com/NousResearch/hermes-agent.git synced 2026-07-29 18:46:59 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 7

fix(desktop): classify router targets by pathname, not the raw target

Browse source 
Every route classifier reasoned about the full navigation target, so a
query put them on the wrong branch: `/skills?tab=mcp` failed the reserved
path check and fell through to the session-id parser as the session
`skills?tab=mcp`, which made `appViewForPath` report Capabilities as a
chat. The command palette reaches Capabilities exclusively through those
targets, and Settings redirects old `/settings?tab=mcp` deep links there.

Strip the query and hash once, up front. Session ids are percent-encoded
by `sessionRoute`, so `?`/`#` can only ever start a query or a hash.
This commit is contained in:
Brooklyn Nicholson 2026-07-27 12:54:39 -05:00
parent 5ecc666146
commit 8323bf3d71
1 changed files with 22 additions and 6 deletions
Download patch file Download diff file Expand all files Collapse all files

28
apps/desktop/src/app/routes.ts
View file

@ -136,16 +136,30 @@ export function isOverlayView(view: AppView): boolean {
return OVERLAY_VIEWS.has(view)
}
/** The pathname of a router target. Every classifier below reasons about a
* PATH, but callers navigate to full targets (`/skills?tab=mcp`), and an
* unstripped query reaches the session-id parser — `/skills?tab=mcp` reads as
* the session `skills?tab=mcp`, so Capabilities classifies as a chat.
* `sessionRoute` percent-encodes ids, so `?`/`#` can only start a query or a
* hash. */
export function routePathname(to: string): string {
const cut = to.search(/[?#]/)
return cut === -1 ? to : to.slice(0, cut)
}
export function isNewChatRoute(pathname: string): boolean {
return pathname === NEW_CHAT_ROUTE
return routePathname(pathname) === NEW_CHAT_ROUTE
}
export function routeSessionId(pathname: string): string | null {
if (!pathname.startsWith(SESSION_ROUTE_PREFIX) || RESERVED_PATHS.has(pathname) || isContributedPath(pathname)) {
const path = routePathname(pathname)
if (!path.startsWith(SESSION_ROUTE_PREFIX) || RESERVED_PATHS.has(path) || isContributedPath(path)) {
return null
}
const id = pathname.slice(SESSION_ROUTE_PREFIX.length)
const id = path.slice(SESSION_ROUTE_PREFIX.length)
return id && !id.includes('/') ? decodeURIComponent(id) : null
}
@ -172,15 +186,17 @@ export function sessionRoute(sessionId: string): string {
}
export function appViewForPath(pathname: string): AppView {
if (isNewChatRoute(pathname) || routeSessionId(pathname)) {
const path = routePathname(pathname)
if (isNewChatRoute(path) || routeSessionId(path)) {
return 'chat'
}
if (isContributedPath(pathname)) {
if (isContributedPath(path)) {
return 'extension'
}
return APP_VIEW_BY_PATH.get(pathname) ?? 'chat'
return APP_VIEW_BY_PATH.get(path) ?? 'chat'
}
/** True while the workspace pane shows a FULL PAGE (skills/messaging/