From 80855f964e4d626857ee1ded783c247ffa50427e Mon Sep 17 00:00:00 2001 From: Teknium <127238744+teknium1@users.noreply.github.com> Date: Thu, 16 Apr 2026 13:34:16 -0700 Subject: [PATCH] fix: stop hermes update from nagging about llm-wiki's wiki.path (#11222) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit llm-wiki was the only shipped skill using metadata.hermes.config, which caused 'hermes update' and 'hermes config migrate' to prompt for a wiki directory on every run — even for users who have never touched the skill — because 'enabled' is opt-out (all shipped skills count as enabled unless explicitly disabled). Declining the prompt didn't persist anything, so the nag fired again on every update. Switch llm-wiki to the env var + runtime default pattern that obsidian and google-workspace already use: WIKI_PATH env var, default $HOME/wiki. No prompting infrastructure, no config.yaml touch, no nag loop. Changes: - skills/research/llm-wiki/SKILL.md: remove metadata.hermes.config, document WIKI_PATH env var in the Wiki Location section, update the orientation snippet and initialization guidance. - Docs: replace llm-wiki's wiki.path examples with a generic 'myplugin.path' placeholder across configuration.md, features/skills.md, and creating-skills.md so users don't try to set skills.config.wiki.path expecting llm-wiki to use it. - skills-catalog.md: mention WIKI_PATH instead of skills.config.wiki.path. E2E verified: discover_all_skill_config_vars() and get_missing_skill_config_vars() both return 0 entries after this change, so the prompt branch in migrate_config() no longer fires. The metadata.hermes.config feature stays in place for third-party skills that genuinely need structured config, but built-ins now prefer env vars. --- skills/research/llm-wiki/SKILL.md | 24 ++++++------------- .../docs/developer-guide/creating-skills.md | 24 +++++++++---------- website/docs/reference/skills-catalog.md | 2 +- website/docs/user-guide/configuration.md | 6 ++--- website/docs/user-guide/features/skills.md | 8 +++---- 5 files changed, 27 insertions(+), 37 deletions(-) diff --git a/skills/research/llm-wiki/SKILL.md b/skills/research/llm-wiki/SKILL.md index 753bc3af0..a90dd0a9b 100644 --- a/skills/research/llm-wiki/SKILL.md +++ b/skills/research/llm-wiki/SKILL.md @@ -9,11 +9,6 @@ metadata: tags: [wiki, knowledge-base, research, notes, markdown, rag-alternative] category: research related_skills: [obsidian, arxiv, agentic-research-ideas] - config: - - key: wiki.path - description: Path to the LLM Wiki knowledge base directory - default: "~/wiki" - prompt: Wiki directory path --- # Karpathy's LLM Wiki @@ -39,19 +34,14 @@ Use this skill when the user: ## Wiki Location -Configured via `skills.config.wiki.path` in `~/.hermes/config.yaml` (prompted -during `hermes config migrate` or `hermes setup`): +**Location:** Set via `WIKI_PATH` environment variable (e.g. in `~/.hermes/.env`). -```yaml -skills: - config: - wiki: - path: ~/wiki +If unset, defaults to `~/wiki`. + +```bash +WIKI="${WIKI_PATH:-$HOME/wiki}" ``` -Falls back to `~/wiki` default. The resolved path is injected when this -skill loads — check the `[Skill config: ...]` block above for the active value. - The wiki is just a directory of markdown files — open it in Obsidian, VS Code, or any editor. No database, no special tooling required. @@ -87,7 +77,7 @@ When the user has an existing wiki, **always orient yourself before doing anythi ③ **Scan recent `log.md`** — read the last 20-30 entries to understand recent activity. ```bash -WIKI="${wiki_path:-$HOME/wiki}" +WIKI="${WIKI_PATH:-$HOME/wiki}" # Orientation reads at session start read_file "$WIKI/SCHEMA.md" read_file "$WIKI/index.md" @@ -107,7 +97,7 @@ at hand before creating anything new. When the user asks to create or start a wiki: -1. Determine the wiki path (from config, env var, or ask the user; default `~/wiki`) +1. Determine the wiki path (from `$WIKI_PATH` env var, or ask the user; default `~/wiki`) 2. Create the directory structure above 3. Ask the user what domain the wiki covers — be specific 4. Write `SCHEMA.md` customized to the domain (see template below) diff --git a/website/docs/developer-guide/creating-skills.md b/website/docs/developer-guide/creating-skills.md index 7ca16bff5..9fdb7fd11 100644 --- a/website/docs/developer-guide/creating-skills.md +++ b/website/docs/developer-guide/creating-skills.md @@ -186,18 +186,18 @@ Skills can declare non-secret settings that are stored in `config.yaml` under th metadata: hermes: config: - - key: wiki.path - description: Path to the LLM Wiki knowledge base directory - default: "~/wiki" - prompt: Wiki directory path - - key: wiki.domain - description: Domain the wiki covers + - key: myplugin.path + description: Path to the plugin data directory + default: "~/myplugin-data" + prompt: Plugin data directory path + - key: myplugin.domain + description: Domain the plugin operates on default: "" - prompt: Wiki domain (e.g., AI/ML research) + prompt: Plugin domain (e.g., AI/ML research) ``` Each entry supports: -- `key` (required) — dotpath for the setting (e.g., `wiki.path`) +- `key` (required) — dotpath for the setting (e.g., `myplugin.path`) - `description` (required) — explains what the setting controls - `default` (optional) — default value if the user doesn't configure it - `prompt` (optional) — prompt text shown during `hermes config migrate`; falls back to `description` @@ -208,8 +208,8 @@ Each entry supports: ```yaml skills: config: - wiki: - path: ~/my-research + myplugin: + path: ~/my-data ``` 2. **Discovery:** `hermes config migrate` scans all enabled skills, finds unconfigured settings, and prompts the user. Settings also appear in `hermes config show` under "Skill Settings." @@ -217,14 +217,14 @@ Each entry supports: 3. **Runtime injection:** When a skill loads, its config values are resolved and appended to the skill message: ``` [Skill config (from ~/.hermes/config.yaml): - wiki.path = /home/user/my-research + myplugin.path = /home/user/my-data ] ``` The agent sees the configured values without needing to read `config.yaml` itself. 4. **Manual setup:** Users can also set values directly: ```bash - hermes config set skills.config.wiki.path ~/my-wiki + hermes config set skills.config.myplugin.path ~/my-data ``` :::tip When to use which diff --git a/website/docs/reference/skills-catalog.md b/website/docs/reference/skills-catalog.md index e3c37ea6e..13ef2f7fc 100644 --- a/website/docs/reference/skills-catalog.md +++ b/website/docs/reference/skills-catalog.md @@ -253,7 +253,7 @@ Skills for academic research, paper discovery, literature review, domain reconna |-------|-------------|------| | `arxiv` | Search and retrieve academic papers from arXiv using their free REST API. No API key needed. Search by keyword, author, category, or ID. Combine with web_extract or the ocr-and-documents skill to read full paper content. | `research/arxiv` | | `blogwatcher` | Monitor blogs and RSS/Atom feeds for updates using the blogwatcher CLI. Add blogs, scan for new articles, and track what you've read. | `research/blogwatcher` | -| `llm-wiki` | Karpathy's LLM Wiki — build and maintain a persistent, interlinked markdown knowledge base. Ingest sources, query compiled knowledge, and lint for consistency. Unlike RAG, the wiki compiles knowledge once and keeps it current. Works as an Obsidian vault. Configurable via `skills.config.wiki.path`. | `research/llm-wiki` | +| `llm-wiki` | Karpathy's LLM Wiki — build and maintain a persistent, interlinked markdown knowledge base. Ingest sources, query compiled knowledge, and lint for consistency. Unlike RAG, the wiki compiles knowledge once and keeps it current. Works as an Obsidian vault. Wiki path is controlled by the `WIKI_PATH` env var (defaults to `~/wiki`). | `research/llm-wiki` | | `domain-intel` | Passive domain reconnaissance using Python stdlib. Subdomain discovery, SSL certificate inspection, WHOIS lookups, DNS records, domain availability checks, and bulk multi-domain analysis. No API keys required. | `research/domain-intel` | | `duckduckgo-search` | Free web search via DuckDuckGo — text, news, images, videos. No API key needed. Prefer the `ddgs` CLI when installed; use the Python DDGS library only after verifying that `ddgs` is available in the current runtime. | `research/duckduckgo-search` | | `ml-paper-writing` | Write publication-ready ML/AI papers for NeurIPS, ICML, ICLR, ACL, AAAI, COLM. Use when drafting papers from research repos, structuring arguments, verifying citations, or preparing camera-ready submissions. Includes LaTeX templates, reviewer guidelines, and citation verificatio… | `research/ml-paper-writing` | diff --git a/website/docs/user-guide/configuration.md b/website/docs/user-guide/configuration.md index 733263207..bef9b5cfd 100644 --- a/website/docs/user-guide/configuration.md +++ b/website/docs/user-guide/configuration.md @@ -359,8 +359,8 @@ Skills can declare their own configuration settings via their SKILL.md frontmatt ```yaml skills: config: - wiki: - path: ~/wiki # Used by the llm-wiki skill + myplugin: + path: ~/myplugin-data # Example — each skill defines its own keys ``` **How skill settings work:** @@ -372,7 +372,7 @@ skills: **Setting values manually:** ```bash -hermes config set skills.config.wiki.path ~/my-research-wiki +hermes config set skills.config.myplugin.path ~/myplugin-data ``` For details on declaring config settings in your own skills, see [Creating Skills — Config Settings](/docs/developer-guide/creating-skills#config-settings-configyaml). diff --git a/website/docs/user-guide/features/skills.md b/website/docs/user-guide/features/skills.md index aead5ac26..c0f2d8d83 100644 --- a/website/docs/user-guide/features/skills.md +++ b/website/docs/user-guide/features/skills.md @@ -155,10 +155,10 @@ Skills can also declare non-secret config settings (paths, preferences) stored i metadata: hermes: config: - - key: wiki.path - description: Path to the wiki directory - default: "~/wiki" - prompt: Wiki directory path + - key: myplugin.path + description: Path to the plugin data directory + default: "~/myplugin-data" + prompt: Plugin data directory path ``` Settings are stored under `skills.config` in your config.yaml. `hermes config migrate` prompts for unconfigured settings, and `hermes config show` displays them. When a skill loads, its resolved config values are injected into the context so the agent knows the configured values automatically.