test(kanban): cover worker session tagging and retag

tests/hermes_cli/test_kanban_worker_session_source.py

@@ -0,0 +1,106 @@
+"""Kanban worker runs must not surface as user conversations.
+
+Workers spawn as `hermes chat -q "work kanban task <id>"`, which used to land in
+state.db as an untitled `cli` row — the desktop sidebar then rendered one entry
+per attempt, labeled with the worker's own prompt.
+"""
+
+import os
+
+import pytest
+
+from hermes_state import SessionDB
+
+
+@pytest.fixture()
+def db(tmp_path, monkeypatch):
+    monkeypatch.setenv("HERMES_HOME", str(tmp_path))
+    database = SessionDB(db_path=tmp_path / "state.db")
+    yield database
+    database.close()
+
+
+def test_worker_spawn_tags_session_source_kanban(monkeypatch, tmp_path):
+    """The dispatcher tags the worker's env so its session is a `kanban` row."""
+    from hermes_cli import kanban_db as kb
+
+    captured = {}
+
+    class _Proc:
+        pid = 4321
+
+    def _fake_popen(cmd, **kwargs):
+        captured["env"] = kwargs["env"]
+        return _Proc()
+
+    monkeypatch.setattr("subprocess.Popen", _fake_popen)
+    monkeypatch.setattr(kb, "_retag_legacy_worker_sessions", lambda _root: None)
+    monkeypatch.setattr(kb, "worker_logs_dir", lambda board=None: tmp_path / "logs")
+
+    task = kb.Task(
+        id="t_b21733fb",
+        title="ship it",
+        body=None,
+        assignee="default",
+        status="in_progress",
+        priority=0,
+        created_by=None,
+        created_at=0,
+        started_at=None,
+        completed_at=None,
+        workspace_kind="scratch",
+        workspace_path=None,
+        claim_lock=None,
+        claim_expires=None,
+        tenant=None,
+    )
+    workspace = str(tmp_path / "ws")
+    os.makedirs(workspace, exist_ok=True)
+
+    kb._default_spawn(task, workspace)
+
+    assert captured["env"]["HERMES_SESSION_SOURCE"] == "kanban"
+
+
+def test_kanban_rows_stay_out_of_the_session_list(db):
+    """A `kanban` row is filtered by the same exclude the sidebar sends."""
+    db.create_session(session_id="chat", source="desktop")
+    db.append_message(session_id="chat", role="user", content="hey")
+    db.create_session(session_id="worker", source="kanban")
+    db.append_message(session_id="worker", role="user", content="work kanban task t_b21733fb")
+
+    listed = db.list_sessions_rich(exclude_sources=["cron", "kanban", "subagent", "tool"])
+
+    assert [row["id"] for row in listed] == ["chat"]
+
+
+def test_retag_reclaims_legacy_worker_rows(db, tmp_path):
+    """Rows written before the tag existed are identified by workspace cwd.
+
+    Two rows, not one: the count has to survive ``set_meta`` reusing the same
+    cursor, which would otherwise report the meta write's rowcount instead.
+    """
+    workspaces = tmp_path / "kanban" / "workspaces"
+    db.create_session(session_id="legacy", source="cli", cwd=str(workspaces / "t_b21733fb"))
+    db.create_session(session_id="legacy2", source="cli", cwd=str(workspaces / "t_c0ffee"))
+    db.create_session(session_id="mine", source="cli", cwd=str(tmp_path / "www" / "repo"))
+
+    assert db.retag_kanban_worker_sessions(str(workspaces)) == 2
+
+    sources = {row[0]: row[1] for row in db._conn.execute("SELECT id, source FROM sessions")}
+    assert sources == {"legacy": "kanban", "legacy2": "kanban", "mine": "cli"}
+
+
+def test_retag_runs_once_per_database(db, tmp_path):
+    """The state_meta gate keeps the retag off every subsequent spawn."""
+    workspaces = tmp_path / "kanban" / "workspaces"
+    db.create_session(session_id="legacy", source="cli", cwd=str(workspaces / "t_a"))
+    db.retag_kanban_worker_sessions(str(workspaces))
+
+    # A row that a *new* worker would never write as `cli`; if the gate leaked,
+    # a later sweep would grab it too.
+    db.create_session(session_id="later", source="cli", cwd=str(workspaces / "t_b"))
+
+    assert db.retag_kanban_worker_sessions(str(workspaces)) == 0
+    row = db._conn.execute("SELECT source FROM sessions WHERE id = 'later'").fetchone()
+    assert row[0] == "cli"