Merge pull request #151 from johnh4098/fix/shell-injection-spawn-via-env-v2

fix(process): escape single quotes in spawn_via_env bg_command
This commit is contained in:
Teknium 2026-02-27 22:49:04 -08:00 committed by GitHub
commit 7f423508e4
No known key found for this signature in database
GPG key ID: B5690EEEBB952194

View file

@ -247,8 +247,9 @@ class ProcessRegistry:
# Run the command in the sandbox with output capture
log_path = f"/tmp/hermes_bg_{session.id}.log"
pid_path = f"/tmp/hermes_bg_{session.id}.pid"
safe_command = command.replace("'", "'\''")
bg_command = (
f"nohup bash -c '{command}' > {log_path} 2>&1 & "
f"nohup bash -c '{safe_command}' > {log_path} 2>&1 & "
f"echo $! > {pid_path} && cat {pid_path}"
)