mirrors/hermes-agent
1
0
Fork 0
mirror of https://github.com/NousResearch/hermes-agent.git synced 2026-04-26 01:01:40 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 5

fix: Address PR review comments for Brave Search

Browse source 
- Fix critical bug: move results initialization inside Firecrawl block
  to prevent overwriting results from parallel/exa/tavily backends
- Fix Brave endpoint path: use 'web/search' instead of '/web/search'
- Remove unrelated TAVILY_API_URL env var override
- Put Brave last in fallback priority (search-only, falls back to Firecrawl)
- Update tests to reflect new fallback order and add Brave-specific tests
- Document fallback priority in _get_backend() docstring
This commit is contained in:
Vito Botta 2026-04-12 15:58:52 +03:00
parent d7ec585479
commit 7ab5bfedde
No known key found for this signature in database
2 changed files with 34 additions and 7 deletions
Download patch file Download diff file Expand all files Collapse all files

24
tests/tools/test_web_tools_config.py
View file

@ -397,6 +397,27 @@ class TestBackendSelection:
patch.dict(os.environ, {"TAVILY_API_KEY": "tvly-test"}):
assert _get_backend() == "tavily"
def test_fallback_brave_only_key(self):
"""Only BRAVE_API_KEY set → 'brave'."""
from tools.web_tools import _get_backend
with patch("tools.web_tools._load_web_config", return_value={}), \
patch.dict(os.environ, {"BRAVE_API_KEY": "brave-test"}):
assert _get_backend() == "brave"
def test_fallback_exa_takes_priority_over_brave(self):
"""Exa should win over Brave in the fallback path (Brave is last priority)."""
from tools.web_tools import _get_backend
with patch("tools.web_tools._load_web_config", return_value={}), \
patch.dict(os.environ, {"BRAVE_API_KEY": "brave-test", "EXA_API_KEY": "exa-test"}):
assert _get_backend() == "exa"
def test_fallback_tavily_takes_priority_over_brave(self):
"""Tavily should win over Brave in the fallback path."""
from tools.web_tools import _get_backend
with patch("tools.web_tools._load_web_config", return_value={}), \
patch.dict(os.environ, {"TAVILY_API_KEY": "tvly-test", "BRAVE_API_KEY": "brave-test"}):
assert _get_backend() == "tavily"
def test_fallback_tavily_with_firecrawl_prefers_firecrawl(self):
"""Tavily + Firecrawl keys, no config → 'firecrawl' (backward compat)."""
from tools.web_tools import _get_backend
@ -429,7 +450,8 @@ class TestBackendSelection:
def test_fallback_no_keys_defaults_to_firecrawl(self):
"""No keys, no config → 'firecrawl' (will fail at client init)."""
from tools.web_tools import _get_backend
with patch("tools.web_tools._load_web_config", return_value={}):
with patch("tools.web_tools._load_web_config", return_value={}), \
patch.dict(os.environ, {"BRAVE_API_KEY": ""}, clear=False):
assert _get_backend() == "firecrawl"
def test_invalid_config_falls_through_to_fallback(self):