mirror of
https://github.com/NousResearch/hermes-agent.git
synced 2026-04-25 00:51:20 +00:00
Normalize FAL_KEY env handling (ignore whitespace-only values)
Treat whitespace-only FAL_KEY the same as unset so users who export FAL_KEY=" " (or CI that leaves a blank token) get the expected 'not set' error path instead of a confusing downstream fal_client failure. Applied to the two direct FAL_KEY checks in image_generation_tool.py: image_generate_tool's upfront credential check and check_fal_api_key(). Both keep the existing managed-gateway fallback intact. Adapted the original whitespace/valid tests to pin the managed gateway to None so the whitespace assertion exercises the direct-key path rather than silently relying on gateway absence.
This commit is contained in:
parent
5e6427a42c
commit
77061ac995
2 changed files with 45 additions and 2 deletions
39
tests/tools/test_image_generation_env.py
Normal file
39
tests/tools/test_image_generation_env.py
Normal file
|
|
@ -0,0 +1,39 @@
|
|||
"""FAL_KEY env var normalization (whitespace-only treated as unset)."""
|
||||
|
||||
|
||||
def test_fal_key_whitespace_is_unset(monkeypatch):
|
||||
# Whitespace-only FAL_KEY must NOT register as configured, and the managed
|
||||
# gateway fallback must be disabled for this assertion to be meaningful.
|
||||
monkeypatch.setenv("FAL_KEY", " ")
|
||||
|
||||
from tools import image_generation_tool
|
||||
|
||||
monkeypatch.setattr(
|
||||
image_generation_tool, "_resolve_managed_fal_gateway", lambda: None
|
||||
)
|
||||
|
||||
assert image_generation_tool.check_fal_api_key() is False
|
||||
|
||||
|
||||
def test_fal_key_valid(monkeypatch):
|
||||
monkeypatch.setenv("FAL_KEY", "sk-test")
|
||||
|
||||
from tools import image_generation_tool
|
||||
|
||||
monkeypatch.setattr(
|
||||
image_generation_tool, "_resolve_managed_fal_gateway", lambda: None
|
||||
)
|
||||
|
||||
assert image_generation_tool.check_fal_api_key() is True
|
||||
|
||||
|
||||
def test_fal_key_empty_is_unset(monkeypatch):
|
||||
monkeypatch.setenv("FAL_KEY", "")
|
||||
|
||||
from tools import image_generation_tool
|
||||
|
||||
monkeypatch.setattr(
|
||||
image_generation_tool, "_resolve_managed_fal_gateway", lambda: None
|
||||
)
|
||||
|
||||
assert image_generation_tool.check_fal_api_key() is False
|
||||
Loading…
Add table
Add a link
Reference in a new issue