mirrors/hermes-agent
1
0
Fork 0
mirror of https://github.com/NousResearch/hermes-agent.git synced 2026-04-25 00:51:20 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions

fix(cli): handle null/non-dict display config in skin initialization

Browse source 
display: null or display: <non-dict> in config.yaml crashed skin init
with AttributeError. Now falls back to default skin gracefully.

Cherry-picked from #10867 by @Bartok9. Consolidates #10876 by @cola-runner.

Co-authored-by: cola-runner <cola-runner@users.noreply.github.com>
This commit is contained in:
Bartok9 2026-04-16 18:40:04 +05:30 • committed by kshitij
parent 465193b7eb
commit 73befa505d
2 changed files with 21 additions and 1 deletions
Download patch file Download diff file Expand all files Collapse all files

4
hermes_cli/skin_engine.py
View file

@ -708,7 +708,9 @@ def init_skin_from_config(config: dict) -> None:
Call this once during CLI init with the loaded config dict.
"""
display = config.get("display", {})
display = config.get("display") or {}
if not isinstance(display, dict):
display = {}
skin_name = display.get("skin", "default")
if isinstance(skin_name, str) and skin_name.strip():
set_active_skin(skin_name.strip())

18
tests/hermes_cli/test_skin_engine.py
View file

@ -152,6 +152,24 @@ class TestSkinManagement:
init_skin_from_config({})
assert get_active_skin_name() == "default"
def test_init_skin_from_null_display(self):
"""display: null should fall back to default, not crash."""
from hermes_cli.skin_engine import init_skin_from_config, get_active_skin_name
init_skin_from_config({"display": None})
assert get_active_skin_name() == "default"
def test_init_skin_from_non_dict_display(self):
"""display: <non-dict> should fall back to default."""
from hermes_cli.skin_engine import init_skin_from_config, get_active_skin_name
init_skin_from_config({"display": "invalid"})
assert get_active_skin_name() == "default"
init_skin_from_config({"display": 42})
assert get_active_skin_name() == "default"
init_skin_from_config({"display": []})
assert get_active_skin_name() == "default"
class TestUserSkins:
def test_load_user_skin_from_yaml(self, tmp_path, monkeypatch):