From 72c013b6622ec1e19b01601c3c8d83b297d364aa Mon Sep 17 00:00:00 2001 From: teknium1 <127238744+teknium1@users.noreply.github.com> Date: Sat, 25 Jul 2026 22:32:43 -0700 Subject: [PATCH] docs(compression): correct the stale in_place default in comments 2107b86024 flipped compression.in_place to True but left both explanatory comments reading "Default False during rollout". The contradiction is load-bearing: it is why two recent PRs (#71747, #48951) were built on the premise that agent.session_id still rotates at every compaction. Comment-only; no behavior change. --- agent/conversation_compression.py | 2 +- hermes_cli/config.py | 4 ++-- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/agent/conversation_compression.py b/agent/conversation_compression.py index 44867e1a521..d2df6f25a39 100644 --- a/agent/conversation_compression.py +++ b/agent/conversation_compression.py @@ -1401,7 +1401,7 @@ def compress_context( # parent_session_id child, no # `name #N` renumber, no contextvar/env/logging re-sync, no memory/context- # engine session-switch. The conversation keeps one durable id for life, - # eliminating the session-rotation bug cluster. Default False during rollout. + # eliminating the session-rotation bug cluster. Default True (2107b86024). in_place = bool(getattr(agent, "compression_in_place", False)) # Set True once the in-place DB write actually completes (the DB block can # raise and skip it). Surfaced to the gateway via agent._last_compaction_in_place. diff --git a/hermes_cli/config.py b/hermes_cli/config.py index 0145244ccbc..ee0bbf9d681 100644 --- a/hermes_cli/config.py +++ b/hermes_cli/config.py @@ -1532,8 +1532,8 @@ DEFAULT_CONFIG = { # turns are soft-archived under the same id # (active=0, compacted=1) — still searchable via # session_search and recoverable, not deleted. - # Default False during rollout; will flip on - # after live validation. + # Default True since 2107b86024; set False to + # restore the legacy rotating-compaction path. "model_thresholds": {}, # Per-model threshold overrides. Keys are # substring-matched against the model name # (longest match wins); values replace the