mirrors/hermes-agent
1
0
Fork 0
mirror of https://github.com/NousResearch/hermes-agent.git synced 2026-04-25 00:51:20 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions

fix(doctor): skip invalid MiniMax models probe

Browse source
This commit is contained in:
Remotework 2026-04-24 18:48:13 -04:00
parent e8062341e3
commit 6e6d7c48c8
2 changed files with 43 additions and 12 deletions
Download patch file Download diff file Expand all files Collapse all files

7
hermes_cli/doctor.py
View file

@ -966,9 +966,10 @@ def run_doctor(args):
("Hugging Face", ("HF_TOKEN",), "https://router.huggingface.co/v1/models", "HF_BASE_URL", True),
("NVIDIA NIM", ("NVIDIA_API_KEY",), "https://integrate.api.nvidia.com/v1/models", "NVIDIA_BASE_URL", True),
("Alibaba/DashScope", ("DASHSCOPE_API_KEY",), "https://dashscope-intl.aliyuncs.com/compatible-mode/v1/models", "DASHSCOPE_BASE_URL", True),
# MiniMax: the /anthropic endpoint doesn't support /models, but the /v1 endpoint does.
("MiniMax", ("MINIMAX_API_KEY",), "https://api.minimax.io/v1/models", "MINIMAX_BASE_URL", True),
("MiniMax (China)", ("MINIMAX_CN_API_KEY",), "https://api.minimaxi.com/v1/models", "MINIMAX_CN_BASE_URL", True),
# MiniMax providers do not expose a shared /models endpoint; skip live health
# probes here and rely on runtime requests / static catalog validation instead.
("MiniMax", ("MINIMAX_API_KEY",), None, "MINIMAX_BASE_URL", False),
("MiniMax (China)", ("MINIMAX_CN_API_KEY",), None, "MINIMAX_CN_BASE_URL", False),
("Vercel AI Gateway", ("AI_GATEWAY_API_KEY",), "https://ai-gateway.vercel.sh/v1/models", "AI_GATEWAY_BASE_URL", True),
("Kilo Code", ("KILOCODE_API_KEY",), "https://api.kilo.ai/api/gateway/models", "KILOCODE_BASE_URL", True),
("OpenCode Zen", ("OPENCODE_ZEN_API_KEY",), "https://opencode.ai/zen/v1/models", "OPENCODE_ZEN_BASE_URL", True),

48
tests/hermes_cli/test_doctor.py
View file

@ -399,22 +399,23 @@ def test_run_doctor_kimi_cn_env_is_detected_and_probe_is_null_safe(monkeypatch,
@pytest.mark.parametrize("base_url", [None, "https://opencode.ai/zen/go/v1"])
def test_run_doctor_opencode_go_skips_invalid_models_probe(monkeypatch, tmp_path, base_url):
def _run_doctor_with_single_api_key_provider(monkeypatch, tmp_path, env_var, env_value, provider_name, base_env=None, base_url=None):
home = tmp_path / ".hermes"
home.mkdir(parents=True, exist_ok=True)
(home / "config.yaml").write_text("memory: {}\n", encoding="utf-8")
(home / ".env").write_text("OPENCODE_GO_API_KEY=***\n", encoding="utf-8")
(home / ".env").write_text(f"{env_var}=***\n", encoding="utf-8")
project = tmp_path / "project"
project.mkdir(exist_ok=True)
monkeypatch.setattr(doctor_mod, "HERMES_HOME", home)
monkeypatch.setattr(doctor_mod, "PROJECT_ROOT", project)
monkeypatch.setattr(doctor_mod, "_DHH", str(home))
monkeypatch.setenv("OPENCODE_GO_API_KEY", "sk-test")
if base_url:
monkeypatch.setenv("OPENCODE_GO_BASE_URL", base_url)
else:
monkeypatch.delenv("OPENCODE_GO_BASE_URL", raising=False)
monkeypatch.setenv(env_var, env_value)
if base_env:
if base_url:
monkeypatch.setenv(base_env, base_url)
else:
monkeypatch.delenv(base_env, raising=False)
fake_model_tools = types.SimpleNamespace(
check_tool_availability=lambda *a, **kw: ([], []),
@ -438,20 +439,49 @@ def test_run_doctor_opencode_go_skips_invalid_models_probe(monkeypatch, tmp_path
import httpx
monkeypatch.setattr(httpx, "get", fake_get)
import io, contextlib
buf = io.StringIO()
with contextlib.redirect_stdout(buf):
doctor_mod.run_doctor(Namespace(fix=False))
out = buf.getvalue()
assert any(
"OpenCode Go" in line and "(key configured)" in line
provider_name in line and "(key configured)" in line
for line in out.splitlines()
)
return out, calls
@pytest.mark.parametrize("base_url", [None, "https://opencode.ai/zen/go/v1"])
def test_run_doctor_opencode_go_skips_invalid_models_probe(monkeypatch, tmp_path, base_url):
_, calls = _run_doctor_with_single_api_key_provider(
monkeypatch,
tmp_path,
env_var="OPENCODE_GO_API_KEY",
env_value="sk-test",
provider_name="OpenCode Go",
base_env="OPENCODE_GO_BASE_URL",
base_url=base_url,
)
assert not any(url == "https://opencode.ai/zen/go/v1/models" for url, _, _ in calls)
assert not any("opencode" in url.lower() and "models" in url.lower() for url, _, _ in calls)
@pytest.mark.parametrize("base_url", [None, "https://api.minimax.io/anthropic"])
def test_run_doctor_minimax_skips_invalid_models_probe(monkeypatch, tmp_path, base_url):
_, calls = _run_doctor_with_single_api_key_provider(
monkeypatch,
tmp_path,
env_var="MINIMAX_API_KEY",
env_value="sk-test",
provider_name="MiniMax",
base_env="MINIMAX_BASE_URL",
base_url=base_url,
)
assert not any("minimax" in url.lower() and "models" in url.lower() for url, _, _ in calls)
def test_run_doctor_reports_tool_governance_settings(monkeypatch, tmp_path):
home = tmp_path / ".hermes"
home.mkdir(parents=True, exist_ok=True)