mirrors/hermes-agent
1
0
Fork 0
mirror of https://github.com/NousResearch/hermes-agent.git synced 2026-04-29 01:31:41 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 6

fix(delegate): clear acp_command when override_provider is set

Browse source 
When delegation.provider is configured (e.g. minimax-cn), subagents
inherited the parent's acp_command unconditionally. This caused
run_agent.py to initialize CopilotACPClient, which bypassed the
override credentials entirely and used its own default model
(provider=copilot-acp model=qwen3.5-397b-a17b) instead of the
configured delegation.provider and delegation.model.

Fix: when override_provider is set but override_acp_command is not,
clear effective_acp_command and effective_acp_args so the child agent
uses direct API calls with the configured provider credentials.

The existing override_acp_command path is unchanged — explicit ACP
transport overrides still force provider=copilot-acp as before.

Fixes #16816
This commit is contained in:
ygd58 2026-04-28 07:23:07 +02:00 • committed by Teknium
parent 54e24f7758
commit 6b6fc28e85
1 changed files with 8 additions and 0 deletions
Download patch file Download diff file Expand all files Collapse all files

8
tools/delegate_tool.py
View file

@ -994,6 +994,14 @@ def _build_child_agent(
else (getattr(parent_agent, "acp_args", []) or [])
)
# When override_provider is set (e.g. delegation.provider: minimax-cn),
# the subagent must use direct API calls — not the parent's ACP transport.
# Inheriting acp_command unconditionally causes run_agent.py to initialize
# CopilotACPClient, bypassing override credentials entirely (issue #16816).
if override_provider and not override_acp_command:
effective_acp_command = None
effective_acp_args = []
if override_acp_command:
# If explicitly forcing an ACP transport override, the provider MUST be copilot-acp
# so run_agent.py initializes the CopilotACPClient.