mirrors/hermes-agent
1
0
Fork 0
mirror of https://github.com/NousResearch/hermes-agent.git synced 2026-05-01 01:51:44 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 6

fix(browser): avoid bogus Chrome launch fallback

Browse source 
Detect an actual Chrome/Chromium executable before printing a manual CDP launch command, including common WSL-mounted Windows browser paths, so /browser connect does not suggest google-chrome when it is unavailable.
This commit is contained in:
Brooklyn Nicholson 2026-04-28 22:18:41 -05:00 • committed by Teknium
parent f10a3df632
commit 69ff114ee2
5 changed files with 69 additions and 24 deletions
Download patch file Download diff file Expand all files Collapse all files

7
tests/test_tui_gateway_server.py
View file

@ -2904,14 +2904,15 @@ def test_browser_manage_connect_default_local_reports_launch_hint(monkeypatch):
)
with patch.dict(sys.modules, {"tools.browser_tool": fake}):
_stub_urlopen(monkeypatch, ok=False)
with patch("hermes_cli.browser_connect.try_launch_chrome_debug", return_value=False):
with patch("hermes_cli.browser_connect.try_launch_chrome_debug", return_value=False), \
patch("hermes_cli.browser_connect.get_chrome_debug_candidates", return_value=[]):
resp = server.handle_request(
{"id": "1", "method": "browser.manage", "params": {"action": "connect"}}
)
assert resp["error"]["code"] == 5031
assert "Start Chrome with remote debugging" in resp["error"]["message"]
assert "google-chrome --remote-debugging-port=9222" in resp["error"]["message"]
assert "No Chrome/Chromium executable was found" in resp["error"]["message"]
assert "--remote-debugging-port=9222" in resp["error"]["message"]
assert "BROWSER_CDP_URL" not in os.environ