mirrors/hermes-agent
1
0
Fork 0
mirror of https://github.com/NousResearch/hermes-agent.git synced 2026-04-30 01:41:43 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 6

fix(browser): avoid bogus Chrome launch fallback

Browse source 
Detect an actual Chrome/Chromium executable before printing a manual CDP launch command, including common WSL-mounted Windows browser paths, so /browser connect does not suggest google-chrome when it is unavailable.
This commit is contained in:
Brooklyn Nicholson 2026-04-28 22:18:41 -05:00 • committed by Teknium
parent f10a3df632
commit 69ff114ee2
5 changed files with 69 additions and 24 deletions
Download patch file Download diff file Expand all files Collapse all files

44
hermes_cli/browser_connect.py
View file

@ -4,6 +4,7 @@ from __future__ import annotations
import os
import platform
import shlex
import shutil
import subprocess
@ -64,6 +65,14 @@ def get_chrome_debug_candidates(system: str) -> list[str]:
"google-chrome", "google-chrome-stable", "chromium-browser",
"chromium", "brave-browser", "microsoft-edge",
)
for base in ("/mnt/c/Program Files", "/mnt/c/Program Files (x86)"):
for parts in (
("Google", "Chrome", "Application", "chrome.exe"),
("Chromium", "Application", "chrome.exe"),
("BraveSoftware", "Brave-Browser", "Application", "brave.exe"),
("Microsoft", "Edge", "Application", "msedge.exe"),
):
add(os.path.join(base, *parts))
return candidates
@ -72,27 +81,29 @@ def chrome_debug_data_dir() -> str:
return str(get_hermes_home() / "chrome-debug")
def manual_chrome_debug_command(port: int = DEFAULT_BROWSER_CDP_PORT, system: str | None = None) -> str:
def _chrome_debug_args(port: int) -> list[str]:
return [
f"--remote-debugging-port={port}",
f"--user-data-dir={chrome_debug_data_dir()}",
"--no-first-run",
"--no-default-browser-check",
]
def manual_chrome_debug_command(port: int = DEFAULT_BROWSER_CDP_PORT, system: str | None = None) -> str | None:
system = system or platform.system()
data_dir = chrome_debug_data_dir()
candidates = get_chrome_debug_candidates(system)
if candidates:
return " ".join(shlex.quote(part) for part in [candidates[0], *_chrome_debug_args(port)])
if system == "Darwin":
return (
'open -a "Google Chrome" --args'
f" --remote-debugging-port={port}"
f' --user-data-dir="{data_dir}"'
f' --user-data-dir="{chrome_debug_data_dir()}"'
" --no-first-run --no-default-browser-check"
)
if system == "Windows":
return (
f"chrome.exe --remote-debugging-port={port}"
f' --user-data-dir="{data_dir}"'
" --no-first-run --no-default-browser-check"
)
return (
f"google-chrome --remote-debugging-port={port}"
f' --user-data-dir="{data_dir}"'
" --no-first-run --no-default-browser-check"
)
return None
def try_launch_chrome_debug(port: int = DEFAULT_BROWSER_CDP_PORT, system: str | None = None) -> bool:
@ -105,10 +116,7 @@ def try_launch_chrome_debug(port: int = DEFAULT_BROWSER_CDP_PORT, system: str |
subprocess.Popen(
[
candidates[0],
f"--remote-debugging-port={port}",
f"--user-data-dir={chrome_debug_data_dir()}",
"--no-first-run",
"--no-default-browser-check",
*_chrome_debug_args(port),
],
stdout=subprocess.DEVNULL,
stderr=subprocess.DEVNULL,