From 69716a2e6f7cb101ea52a350df6f9dce92cb89a5 Mon Sep 17 00:00:00 2001 From: kshitijk4poor <82637225+kshitijk4poor@users.noreply.github.com> Date: Sat, 20 Jun 2026 01:50:15 +0530 Subject: [PATCH] docs(compression): fix stale 'discarded' wording on in_place config flag MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Review nit (yoniebans): the config.py comment still said compaction is 'lossy: the pre-compaction transcript is discarded, matching Claude Code / Codex' — leftover from the original destructive design. The shipped behavior is soft-archive: lossy for the LIVE context (what the model reloads), but the pre-compaction turns are kept on disk (active=0, compacted=1), searchable via session_search and recoverable. Comment now says so. Comment-only; no behavior change. --- hermes_cli/config.py | 9 ++++++--- 1 file changed, 6 insertions(+), 3 deletions(-) diff --git a/hermes_cli/config.py b/hermes_cli/config.py index ba654a21e74..260d0da5c2b 100644 --- a/hermes_cli/config.py +++ b/hermes_cli/config.py @@ -1295,9 +1295,12 @@ DEFAULT_CONFIG = { # renumbering). Eliminates the session-rotation # bug cluster (#33618 /goal loss, #14238 lost # response, #33907 orphans, #45117 search gaps, - # #42228 null cwd) — see #38763. Compaction is - # lossy: the pre-compaction transcript is - # discarded, matching Claude Code / Codex. + # #42228 null cwd) — see #38763. Non-destructive: + # the live context is compacted (lossy for what + # the model reloads), but the pre-compaction + # turns are soft-archived under the same id + # (active=0, compacted=1) — still searchable via + # session_search and recoverable, not deleted. # Default False during rollout; will flip on # after live validation. },