mirror of
https://github.com/NousResearch/hermes-agent.git
synced 2026-05-08 03:01:47 +00:00
refactor(types): simplify pass on P1 batch
Follow-up to 15ac253b per /simplify review:
- gateway/platforms/discord.py:3638 - move self.resolved = True *after*
the `if interaction.data is None: return` guard. Previously the view
was marked resolved before the None-guard, so a None data payload
silently rejected the user's next click.
- agent/display.py:732 - replace `if self.start_time is None: continue`
with `assert self.start_time is not None`. start() sets start_time
before the animate thread starts, so the None branch was dead; the
`continue` form would have busy-looped (skipping the 0.12s sleep).
- tests/hermes_cli/test_config_shapes.py - drop __total__ dunder
restatement test (it just echoes the class declaration); trim commit
narration from module docstring.
- tests/agent/test_credential_pool.py, tests/tools/test_rl_training_tool.py -
drop "added in commit ..." banners (narrates the change per CLAUDE.md).
This commit is contained in:
parent
a9ed7cb3b4
commit
67bc441099
5 changed files with 5 additions and 29 deletions
|
|
@ -120,12 +120,7 @@ class TestStopTrainingRunProcesses:
|
|||
trainer.terminate.assert_not_called()
|
||||
|
||||
|
||||
# ---------------------------------------------------------------------------
|
||||
# Tests for RunState log_file fields (added in commit fc00f699)
|
||||
# ---------------------------------------------------------------------------
|
||||
|
||||
class TestRunStateLogFileFields:
|
||||
"""Verify api_log_file, trainer_log_file, env_log_file exist with None defaults."""
|
||||
|
||||
def test_log_file_fields_default_none(self):
|
||||
"""All three log_file fields should default to None."""
|
||||
|
|
|
|||
Loading…
Add table
Add a link
Reference in a new issue