mirrors/hermes-agent
1
0
Fork 0
mirror of https://github.com/NousResearch/hermes-agent.git synced 2026-07-31 19:16:29 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 2

fix(cli): stop hard-wrapping streamed paragraphs; prefer OSC 52 over SSH

Browse source 
Streamed responses no longer insert real newlines at terminal width —
logical lines are emitted whole and the terminal soft-wraps them, so
highlight-copy rejoins the full line (emulators only keep linebreaks
the app actually printed). This is the CLI equivalent of the TUI's
selection copy, which reads logical source lines from its screen
buffer. TTFT perception is preserved by mirroring the unfinished
line's tail into the spinner status text instead of chunk-printing.

/copy now prefers OSC 52 when running over SSH (SSH_CONNECTION /
SSH_TTY / SSH_CLIENT) — native tools there write the REMOTE clipboard,
which is never what the user wants. The CLI's OSC 52 writer also gains
tmux/screen DCS passthrough wrapping, mirroring the TUI's
wrapForMultiplexer. Fixes #31528 for the CLI surface.

Sabotage-verified: restoring the old chunk emitter fails 3 of the new
tests (hard-wrap detection, spinner mirror, unbreakable-run split).
This commit is contained in:
Teknium 2026-07-29 00:22:25 -07:00
parent 644590369f
commit 64beb25a35
6 changed files with 190 additions and 44 deletions
Download patch file Download diff file Expand all files Collapse all files

29
tests/cli/test_cli_copy_command.py
View file

@ -65,12 +65,41 @@ def test_copy_falls_back_to_osc52_when_native_tools_fail():
cli_obj.conversation_history = [{"role": "assistant", "content": "hello"}]
with patch("hermes_cli.clipboard.write_clipboard_text", return_value=False), \
patch("hermes_cli.clipboard.is_remote_shell_session", return_value=False), \
patch.object(cli_obj, "_write_osc52_clipboard") as mock_osc52:
cli_obj.process_command("/copy")
mock_osc52.assert_called_once_with("hello")
def test_copy_prefers_osc52_in_ssh_sessions():
"""Over SSH, native tools write the REMOTE clipboard — OSC 52 reaches
the local terminal instead (#31528)."""
cli_obj = _make_cli()
cli_obj.conversation_history = [{"role": "assistant", "content": "remote answer"}]
with patch("hermes_cli.clipboard.write_clipboard_text", return_value=True) as mock_native, \
patch("hermes_cli.clipboard.is_remote_shell_session", return_value=True), \
patch.object(cli_obj, "_write_osc52_clipboard") as mock_osc52:
cli_obj.process_command("/copy")
mock_osc52.assert_called_once_with("remote answer")
mock_native.assert_not_called()
def test_copy_native_first_when_local():
cli_obj = _make_cli()
cli_obj.conversation_history = [{"role": "assistant", "content": "local answer"}]
with patch("hermes_cli.clipboard.write_clipboard_text", return_value=True) as mock_native, \
patch("hermes_cli.clipboard.is_remote_shell_session", return_value=False), \
patch.object(cli_obj, "_write_osc52_clipboard") as mock_osc52:
cli_obj.process_command("/copy")
mock_native.assert_called_once_with("local answer")
mock_osc52.assert_not_called()
def test_copy_invalid_index_does_not_copy():
cli_obj = _make_cli()
cli_obj.conversation_history = [{"role": "assistant", "content": "only"}]