mirrors/hermes-agent
1
0
Fork 0
mirror of https://github.com/NousResearch/hermes-agent.git synced 2026-07-21 16:18:55 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 8

perf(desktop): stop the file tree going sticky during agent edit bursts

Browse source 
revalidateTree runs on every $workspaceChangeTick (mutating-tool completion,
coalesced ~500ms). Two costs per tick, gone:

1. clearProjectDirCache() wiped the gitroot + gitignore caches. But listings are
   read fresh every time (readProjectDir never caches them), so the wipe bought
   nothing except forcing a full re-read of every ancestor .gitignore — each a
   full readdir — for every loaded dir, every tick. Dropped; a .gitignore edit is
   still picked up on the next full refresh (cwd/connection change / manual).
2. reconcile awaited each child dir serially, crawling a wide/deep tree one dir
   at a time. Now Promise.all over siblings (order preserved), recursing per
   loaded subfolder.

use-project-tree.test.ts + right-sidebar/index.test.tsx green (15). tsc + eslint clean.
This commit is contained in:
Brooklyn Nicholson 2026-07-19 21:43:35 -05:00
parent 7f12d4f890
commit 61bda4f3ca
1 changed files with 17 additions and 14 deletions
Download patch file Download diff file Expand all files Collapse all files

31
apps/desktop/src/app/right-sidebar/files/use-project-tree.ts
View file

@ -233,7 +233,11 @@ async function revalidateTree(cwd: string): Promise<void> {
}
const rootPath = state.resolvedCwd || cwd
clearProjectDirCache()
// Don't wipe the gitroot/gitignore caches here. Listings are read fresh
// (readProjectDir never caches them), so new/deleted files surface anyway;
// wiping forced a full re-read of every ancestor .gitignore on every edit
// tick (~500ms), which made the tree sticky mid-burst. A .gitignore edit is
// picked up on the next full refresh (cwd/connection change / manual refresh).
const reconcile = async (dirPath: string, existing: TreeNode[]): Promise<TreeNode[]> => {
const { entries, error } = await readProjectDir(dirPath, rootPath)
@ -243,22 +247,21 @@ async function revalidateTree(cwd: string): Promise<void> {
}
const byId = new Map(existing.filter(node => !node.placeholder).map(node => [node.id, node]))
const merged: TreeNode[] = []
for (const entry of entries) {
const prev = byId.get(entry.path)
// Reconcile siblings concurrently (Promise.all preserves order); loaded
// subfolders recurse so deep edits surface without a re-expand. Awaiting
// each child serially crawled a wide/deep tree one dir at a time per tick.
return Promise.all(
entries.map(async entry => {
const prev = byId.get(entry.path)
if (prev?.isDirectory && prev.children) {
// Loaded folder: recurse so deep edits surface without a re-expand.
merged.push({ ...prev, children: await reconcile(prev.id, prev.children) })
} else if (prev) {
merged.push(prev)
} else {
merged.push(makeNode(entry.path, entry.name, entry.isDirectory))
}
}
if (prev?.isDirectory && prev.children) {
return { ...prev, children: await reconcile(prev.id, prev.children) }
}
return merged
return prev ?? makeNode(entry.path, entry.name, entry.isDirectory)
})
)
}
const nextData = await reconcile(rootPath, state.data)