mirror of
https://github.com/NousResearch/hermes-agent.git
synced 2026-05-29 06:31:32 +00:00
chore: ruff auto-fix PLR6201 resweep — tuple → set in membership tests (#27355)
Six days after #23937 (608 fixes) the codebase had accumulated 241 new PLR6201 violations. Same mechanical `x in (...)` → `x in {...}` fix, same zero-risk profile: set lookup is O(1) vs O(n) for tuple and the two are semantically equivalent for hashable scalar membership tests. All 241 instances fixed via `ruff check --select PLR6201 --fix --unsafe-fixes`, zero remaining. Every changed value is a hashable scalar (str/int/None/enum/signal); no risk of unhashable runtime errors. No behavior change. Test plan: - 119 files changed, +244/-244 (net zero) — exactly one-line edits - `ruff check` clean afterward - Compile checks pass on the largest touched files (cli.py, run_agent.py, gateway/run.py, gateway/platforms/discord.py, model_tools.py) - Subset broad test run on tests/gateway/ tests/hermes_cli/ tests/agent/ tests/tools/: 18187 passed, 59 pre-existing failures (verified against origin/main with the same shape — identical failure count, identical category — all xdist test-order flakes unrelated to this change) Follows the same template as PR #23937 ([tracker: #23972](https://github.com/NousResearch/hermes-agent/issues/23972)).
This commit is contained in:
parent
ad00777f04
commit
5fba236644
119 changed files with 244 additions and 244 deletions
|
|
@ -1539,7 +1539,7 @@ class GoogleChatAdapter(BasePlatformAdapter):
|
|||
if sender_email and space_name:
|
||||
self._last_sender_by_chat[space_name] = sender_email.strip().lower()
|
||||
|
||||
chat_type = "dm" if space_type in ("DIRECT_MESSAGE", "DM") else "group"
|
||||
chat_type = "dm" if space_type in {"DIRECT_MESSAGE", "DM"} else "group"
|
||||
text = msg.get("argumentText") or msg.get("text") or ""
|
||||
text = text.strip()
|
||||
|
||||
|
|
@ -1935,7 +1935,7 @@ class GoogleChatAdapter(BasePlatformAdapter):
|
|||
return True
|
||||
except HttpError as exc:
|
||||
status = getattr(getattr(exc, "resp", None), "status", None)
|
||||
if status in (403, 404):
|
||||
if status in {403, 404}:
|
||||
return False
|
||||
logger.debug(
|
||||
"[GoogleChat] delete_message failed: %s",
|
||||
|
|
@ -1958,7 +1958,7 @@ class GoogleChatAdapter(BasePlatformAdapter):
|
|||
update_mask = ",".join(update_mask_fields) or "text"
|
||||
|
||||
# Patch body cannot carry thread (immutable).
|
||||
patch_body = {k: v for k, v in body.items() if k not in ("thread",)}
|
||||
patch_body = {k: v for k, v in body.items() if k not in {"thread",}}
|
||||
|
||||
def _do_patch() -> Dict[str, Any]:
|
||||
return (
|
||||
|
|
@ -2791,7 +2791,7 @@ class GoogleChatAdapter(BasePlatformAdapter):
|
|||
upload_resp = await asyncio.to_thread(_upload)
|
||||
except HttpError as exc:
|
||||
status = getattr(getattr(exc, "resp", None), "status", None)
|
||||
if status in (401, 403):
|
||||
if status in {401, 403}:
|
||||
logger.warning(
|
||||
"[GoogleChat] media.upload auth failure for identity=%s "
|
||||
"(token revoked or scope missing) — falling back to "
|
||||
|
|
@ -2927,7 +2927,7 @@ class GoogleChatAdapter(BasePlatformAdapter):
|
|||
display = info.get("displayName") or chat_id
|
||||
return {
|
||||
"name": display,
|
||||
"type": "dm" if space_type in ("DIRECT_MESSAGE", "DM") else "group",
|
||||
"type": "dm" if space_type in {"DIRECT_MESSAGE", "DM"} else "group",
|
||||
"chat_id": chat_id,
|
||||
}
|
||||
|
||||
|
|
|
|||
Loading…
Add table
Add a link
Reference in a new issue