From 5e8dfc9f6dad585b23502e8cd142e6e45d3f024c Mon Sep 17 00:00:00 2001 From: Teknium <127238744+teknium1@users.noreply.github.com> Date: Fri, 8 May 2026 11:20:43 -0700 Subject: [PATCH] fix(teams-pipeline): fill in missing delivery URL in adapter-reuse test MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit test_build_pipeline_runtime_reuses_existing_teams_adapter_surface set delivery_mode='incoming_webhook' but omitted incoming_webhook_url. _teams_delivery_is_configured() requires the URL to mark delivery as enabled, so the guarded build_pipeline_runtime gate in runtime.py correctly left teams_sender=None and the assertion failed. The intent of the test — prove we reuse the existing TeamsSummaryWriter from plugins/platforms/teams/adapter.py rather than introducing a new adapter surface elsewhere — is unchanged. Added the URL so the gate passes and the architectural assertion holds. --- tests/plugins/test_teams_pipeline_plugin.py | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/tests/plugins/test_teams_pipeline_plugin.py b/tests/plugins/test_teams_pipeline_plugin.py index 8e929b0b8c..862b539972 100644 --- a/tests/plugins/test_teams_pipeline_plugin.py +++ b/tests/plugins/test_teams_pipeline_plugin.py @@ -98,7 +98,10 @@ def test_build_pipeline_runtime_reuses_existing_teams_adapter_surface(monkeypatc platforms={ Platform("teams"): PlatformConfig( enabled=True, - extra={"delivery_mode": "incoming_webhook"}, + extra={ + "delivery_mode": "incoming_webhook", + "incoming_webhook_url": "https://example.com/hook", + }, ) } )