mirrors/hermes-agent
1
0
Fork 0
mirror of https://github.com/NousResearch/hermes-agent.git synced 2026-04-25 00:51:20 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions

fix: respect per-platform disabled skills in Telegram menu and gateway dispatch (#4799)

Browse source 
Three interconnected bugs caused `hermes skills config` per-platform
settings to be silently ignored:

1. telegram_menu_commands() never filtered disabled skills — all skills
   consumed menu slots regardless of platform config, hitting Telegram's
   100 command cap. Now loads disabled skills for 'telegram' and excludes
   them from the menu.

2. Gateway skill dispatch executed disabled skills because
   get_skill_commands() (process-global cache) only filters by the global
   disabled list at scan time. Added per-platform check before execution,
   returning an actionable 'skill is disabled' message.

3. get_disabled_skill_names() only checked HERMES_PLATFORM env var, but
   the gateway sets HERMES_SESSION_PLATFORM instead. Added
   HERMES_SESSION_PLATFORM as fallback, plus an explicit platform=
   parameter for callers that know their platform (menu builder, gateway
   dispatch). Also added platform to prompt_builder's skills cache key
   so multi-platform gateways get correct per-platform skill prompts.

Reported by SteveSkedasticity (CLAW community).
This commit is contained in:
Teknium 2026-04-03 10:10:53 -07:00 • committed by GitHub
parent b6f9b70afd
commit 5db630aae4
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
6 changed files with 196 additions and 5 deletions
Download patch file Download diff file Expand all files Collapse all files

41
tests/hermes_cli/test_commands.py
View file

@ -587,3 +587,44 @@ class TestTelegramMenuCommands:
assert 1 <= len(name) <= _TG_NAME_LIMIT, (
f"Command '{name}' is {len(name)} chars (limit {_TG_NAME_LIMIT})"
)
def test_excludes_telegram_disabled_skills(self, tmp_path, monkeypatch):
"""Skills disabled for telegram should not appear in the menu."""
from unittest.mock import patch, MagicMock
# Set up a config with a telegram-specific disabled list
config_file = tmp_path / "config.yaml"
config_file.write_text(
"skills:\n"
" platform_disabled:\n"
" telegram:\n"
" - my-disabled-skill\n"
)
monkeypatch.setenv("HERMES_HOME", str(tmp_path))
# Mock get_skill_commands to return two skills
fake_skills_dir = str(tmp_path / "skills")
fake_cmds = {
"/my-disabled-skill": {
"name": "my-disabled-skill",
"description": "Should be hidden",
"skill_md_path": f"{fake_skills_dir}/my-disabled-skill/SKILL.md",
"skill_dir": f"{fake_skills_dir}/my-disabled-skill",
},
"/my-enabled-skill": {
"name": "my-enabled-skill",
"description": "Should be visible",
"skill_md_path": f"{fake_skills_dir}/my-enabled-skill/SKILL.md",
"skill_dir": f"{fake_skills_dir}/my-enabled-skill",
},
}
with (
patch("agent.skill_commands.get_skill_commands", return_value=fake_cmds),
patch("tools.skills_tool.SKILLS_DIR", tmp_path / "skills"),
):
(tmp_path / "skills").mkdir(exist_ok=True)
menu, hidden = telegram_menu_commands(max_commands=100)
menu_names = {n for n, _ in menu}
assert "my_enabled_skill" in menu_names
assert "my_disabled_skill" not in menu_names