From 5c7993ec606ff4ff3694630262e2f191beddb506 Mon Sep 17 00:00:00 2001 From: ethernet Date: Mon, 20 Jul 2026 17:08:02 -0400 Subject: [PATCH] fix(ci): add detect to all-checks-pass needs so its failure blocks merge MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit If detect fails, all downstream sub-workflows get SKIPPED (they have needs: detect). all-checks-pass used if: always() and only checked the sub-workflows — which all showed as 'skipped' (= success) — so it passed even though the root cause (detect) failed. This made the PR mergeable despite a broken CI pipeline. Add detect to all-checks-pass needs so its failure propagates to the gate job and blocks the merge. --- .github/workflows/ci.yml | 1 + 1 file changed, 1 insertion(+) diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index 6bb8876bcf17..9cf15a1a6e02 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -259,6 +259,7 @@ jobs: all-checks-pass: name: All required checks pass needs: + - detect - tests - lint - js-tests