mirror of
https://github.com/NousResearch/hermes-agent.git
synced 2026-04-25 00:51:20 +00:00
style(honcho): hoist hashlib import; validate baseUrl scheme before 'local' sentinel
Two small follow-ups to the PR review: - Hoist hashlib import from _enforce_session_id_limit() to module top. stdlib imports are free after first cache, but keeping all imports at module top matches the rest of the codebase. - _resolve_api_key now URL-parses baseUrl and requires http/https + non-empty netloc before returning the 'local' sentinel. A typo like baseUrl: 'true' (or bare 'localhost') no longer silently passes the credential guard; the CLI correctly reports 'not configured'. Three new tests cover the new validation (garbage strings, non-http schemes, valid https).
This commit is contained in:
parent
edc23e888d
commit
5a6a0e2d38
3 changed files with 40 additions and 5 deletions
|
|
@ -41,6 +41,33 @@ class TestResolveApiKey:
|
|||
monkeypatch.delenv("HONCHO_BASE_URL", raising=False)
|
||||
assert honcho_cli._resolve_api_key({}) == ""
|
||||
|
||||
def test_rejects_garbage_base_url_without_scheme(self, monkeypatch):
|
||||
"""A non-URL string in baseUrl (typo) must not pass the guard."""
|
||||
import plugins.memory.honcho.cli as honcho_cli
|
||||
monkeypatch.setattr(honcho_cli, "_host_key", lambda: "hermes")
|
||||
monkeypatch.delenv("HONCHO_API_KEY", raising=False)
|
||||
monkeypatch.delenv("HONCHO_BASE_URL", raising=False)
|
||||
for garbage in ("true", "yes", "1", "localhost", "10.0.0.5"):
|
||||
assert honcho_cli._resolve_api_key({"baseUrl": garbage}) == "", \
|
||||
f"expected empty for garbage {garbage!r}"
|
||||
|
||||
def test_rejects_non_http_scheme_base_url(self, monkeypatch):
|
||||
"""Only http/https schemes are accepted; file:// / ftp:// are not."""
|
||||
import plugins.memory.honcho.cli as honcho_cli
|
||||
monkeypatch.setattr(honcho_cli, "_host_key", lambda: "hermes")
|
||||
monkeypatch.delenv("HONCHO_API_KEY", raising=False)
|
||||
monkeypatch.delenv("HONCHO_BASE_URL", raising=False)
|
||||
for bad in ("file:///etc/passwd", "ftp://host/", "ws://host/"):
|
||||
assert honcho_cli._resolve_api_key({"baseUrl": bad}) == "", \
|
||||
f"expected empty for scheme of {bad!r}"
|
||||
|
||||
def test_accepts_https_base_url(self, monkeypatch):
|
||||
import plugins.memory.honcho.cli as honcho_cli
|
||||
monkeypatch.setattr(honcho_cli, "_host_key", lambda: "hermes")
|
||||
monkeypatch.delenv("HONCHO_API_KEY", raising=False)
|
||||
monkeypatch.delenv("HONCHO_BASE_URL", raising=False)
|
||||
assert honcho_cli._resolve_api_key({"baseUrl": "https://honcho.example.com"}) == "local"
|
||||
|
||||
|
||||
class TestCmdStatus:
|
||||
def test_reports_connection_failure_when_session_setup_fails(self, monkeypatch, capsys, tmp_path):
|
||||
|
|
|
|||
Loading…
Add table
Add a link
Reference in a new issue