mirrors/hermes-agent
1
0
Fork 0
mirror of https://github.com/NousResearch/hermes-agent.git synced 2026-05-18 04:41:56 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 7

fix(mcp): pre-compile env-var regex and unify interpolation

Browse source 
Remove redundant inner `import re` and regex recompilation on every call in
_interpolate_env_vars. Add module-level _ENV_VAR_PATTERN compiled once.

Replace the separate _interpolate_value() in mcp_config.py (which used \w+
and would silently fail on env vars containing hyphens or dots) with the
shared _ENV_VAR_PATTERN from mcp_tool.py. Remove now-unused import re.
This commit is contained in:
Animesh Mishra 2026-03-24 07:20:51 +00:00 • committed by Teknium
parent 5360b54244
commit 55f3262e78
2 changed files with 8 additions and 9 deletions
Download patch file Download diff file Expand all files Collapse all files

7
tools/mcp_tool.py
View file

@ -279,6 +279,11 @@ _CREDENTIAL_PATTERN = re.compile(
re.IGNORECASE,
)
# Pre-compiled pattern for ${VAR_NAME} style env-var interpolation.
# Supports any non-} characters in the variable name (hyphens, dots, etc.)
# so providers like MY-VAR or my.var work correctly.
_ENV_VAR_PATTERN = re.compile(r"\$\{([^}]+)\}")
# ---------------------------------------------------------------------------
# Security helpers
@ -2104,7 +2109,7 @@ def _interpolate_env_vars(value):
if isinstance(value, str):
def _replace(m):
return os.environ.get(m.group(1), m.group(0))
return re.sub(r"\$\{([^}]+)\}", _replace, value)
return _ENV_VAR_PATTERN.sub(_replace, value)
if isinstance(value, dict):
return {k: _interpolate_env_vars(v) for k, v in value.items()}
if isinstance(value, list):